Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify image pull secret documentation #48718

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clarify image pull secret documentation #48718

wants to merge 2 commits into from

Conversation

Jamstah
Copy link

@Jamstah Jamstah commented Nov 14, 2024

Description

The statement about missing pull secrets is incorrect, the kubelet will still attempt to pull the image if a pull secret is missing.

Added some information about how multiple pull secrets are handled.

Issue

Closes: n/a

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Jamstah!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 14, 2024
@Jamstah
Copy link
Author

Jamstah commented Nov 14, 2024

Shout out to https://medium.com/pareture/how-using-multiple-k8s-imagepullsecrets-works-77d2a2ca7a47

@Jamstah Jamstah mentioned this pull request Nov 14, 2024
Open
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 69316f0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673668b3386d3e000830249a
😎 Deploy Preview https://deploy-preview-48718--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jamstah
Clarify image pull secret documentation
1534db3 
The statement about missing pull secrets is incorrect, the kubelet will still attempt to pull the image if a pull secret is missing.

Added some information about how multiple pull secrets are handled.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
@Jamstah Jamstah force-pushed the image-pull-secret-clarification branch from 8cdbb59 to 1534db3 Compare November 14, 2024 14:19
@Jamstah Jamstah mentioned this pull request Nov 14, 2024
Open
@Jamstah @salaxander
Update content/en/docs/tasks/configure-pod-container/pull-image-priva…
69316f0 
…te-registry.md

Co-authored-by: Xander Grzywinski <xandergrzyw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salaxander salaxander salaxander left review comments

@thockin thockin Awaiting requested review from thockin

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jamstah @k8s-ci-robot @salaxander