Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hami to Kubernetes device plugin examples #48866

Merged
merged 1 commit into from
Dec 6, 2024
Merged

add hami to Kubernetes device plugin examples #48866

merged 1 commit into from
Dec 6, 2024

Conversation

wawa0210
Copy link
Contributor

Description

add hami to Kubernetes device plugin examples

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2024
@T-Lakshmi
Copy link
Contributor

Hello @wawa0210,
Thanks for your contribution. It appears that this PR includes changes to files across multiple languages English (en) and Chinese (zh-cn). However, docs follows different processes for each localization, and we typically don't accept pull requests that impact multiple languages simultaneously. I would recommend modify only in primary language(English) initially with this PR. After the merge of the English content, you can create separate pull request for the remaining language(s).

@T-Lakshmi
Copy link
Contributor

Explicit hold until this PR only covers one language.
(Ok to unhold once that's done)
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f4a392d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67513f98067dee0008325c16
😎 Deploy Preview https://deploy-preview-48866--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wawa0210
Copy link
Contributor Author

Explicit hold until this PR only covers one language. (Ok to unhold once that's done) /hold

Thanks for the reminder, I have changed to a one language

@T-Lakshmi
Copy link
Contributor

/remove-language zh
/unhold

@k8s-ci-robot k8s-ci-robot removed language/zh Issues or PRs related to Chinese language do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 27, 2024
@sftim
Copy link
Contributor

sftim commented Nov 28, 2024

/remove-area localization

@k8s-ci-robot k8s-ci-robot removed the area/localization General issues or PRs related to localization label Nov 28, 2024
@wawa0210 wawa0210 force-pushed the main branch 3 times, most recently from cc79046 to bc8e295 Compare November 29, 2024 05:06
@wawa0210 wawa0210 requested a review from windsonsea November 29, 2024 05:06
@wawa0210
Copy link
Contributor Author

Thanks your review, already update.

katcosgrove
katcosgrove reviewed Dec 1, 2024
View reviewed changes
content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md Outdated
@@ -486,6 +486,7 @@ Here are some examples of device plugin implementations:
* [Akri](https://github.com/project-akri/akri), which lets you easily expose heterogeneous leaf devices (such as IP cameras and USB devices).
* The [AMD GPU device plugin](https://github.com/ROCm/k8s-device-plugin)
* The [generic device plugin](https://github.com/squat/generic-device-plugin) for generic Linux devices and USB devices
* The [HAMi](https://github.com/Project-HAMi/HAMi) for heterogeneous ai computing virtualization middleware. (For example, NVIDIA, Cambricon, Hygon, Iluvatar, MThreads, Ascend, Metax.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical correction. After that, you're good to go

Suggested change
* The [HAMi](https://github.com/Project-HAMi/HAMi) for heterogeneous ai computing virtualization middleware. (For example, NVIDIA, Cambricon, Hygon, Iluvatar, MThreads, Ascend, Metax.)
* The [HAMi](https://github.com/Project-HAMi/HAMi) for heterogeneous AI computing virtualization middleware (for example, NVIDIA, Cambricon, Hygon, Iluvatar, MThreads, Ascend, Metax)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks your review, done

@wawa0210
add hami to Kubernetes device-plugin
f4a392d 
Signed-off-by: Xiao Zhang <xiaozhang0210@hotmail.com>
@wawa0210 wawa0210 requested a review from katcosgrove December 5, 2024 05:54
sftim
sftim reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e447560880318ebac1cbb11ee0a5451f10062acd

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit a1918b7 into kubernetes:main Dec 6, 2024
6 checks passed
@wawa0210 wawa0210 deleted the main branch December 26, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@Princesso Princesso Awaiting requested review from Princesso

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

@windsonsea windsonsea Awaiting requested review from windsonsea

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wawa0210 @T-Lakshmi @sftim @k8s-ci-robot @katcosgrove @windsonsea