Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up policy/node-resource-managers.md #49108

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented Dec 16, 2024

Performed actions below:

  • wrap long lines
  • provide a consistent look for bullets
  • fix a : bullet list
  • remove trailing spaces

See preview

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 16, 2024
@k8s-ci-robot k8s-ci-robot requested a review from klueska December 16, 2024 02:21
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2024
@@ -182,27 +185,38 @@ equal to one. The `nginx` container is granted 2 exclusive CPUs.

#### Static policy options {#cpu-policy-static--options}

The behavior of the static policy can be fine-tuned using the CPU Manager policy options.
The following policy options exist for the static CPU management policy:
{{/* options in alphabetical order */}}
Copy link
Member Author

@windsonsea windsonsea Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This {{/* options */ }} variable doesn't work on the current website page.
A review is required to my changes below. See preview.

Copy link

netlify bot commented Dec 16, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2dc4f56
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/675f8e8ade955800087ae1b6
😎 Deploy Preview https://deploy-preview-49108--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7e25b6d21da83ac17e49418a91ad23ed0b48af52

Copy link
Member

@my-git9 my-git9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@dipesh-rawat
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 17, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat, my-git9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 641ea80 into kubernetes:main Jan 17, 2025
6 checks passed
@windsonsea windsonsea deleted the nodeger branch January 17, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants