Skip to content

Conversation

@dkarczmarski
Copy link
Member

fix a small inconsistency .

replace ".template.spec" with ".spec.template.spec" .

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2025
@netlify
Copy link

netlify bot commented Jan 22, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8bea986
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6791d88dc8c8d00008026e92
😎 Deploy Preview https://deploy-preview-49527--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dkarczmarski
Copy link
Member Author

this:
"
The Pods are labeled app: nginxusing the .metadata.labels field.
"
also should be replace with ".spec.template.metadata.labels"
for consistency

... or it might be fixed in another way:


... because there is the sentence:
"The template field contains the following sub-fields:"
with "sub-fields:" so it might sugest that we can skip ".spec.template" as these are "sub-fields".

and then, this
"
The Pod template's specification, or .template.spec field,
"

can be replaced with:

"
The Pod template's specification, or .spec field,
"

and then for consistency we should remove ".spec.templace" from
"Create one container and name it nginx using the .spec.template.spec.containers[0].name field."


but it think my first fix is better because it is more precise

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@network-charles
Copy link
Contributor

It looks great. You can squash your commits.

@network-charles
Copy link
Contributor

/lgtm

cc @natalisucks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 78336d73be27b198e6768571d649a36fedeaceea

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 874c61d into kubernetes:main Jan 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants