Skip to content

Add docs for PSAT for Kubelet Image Credential Providers alpha #49884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Add docs for PSAT for Kubelet Image Credential Providers alpha #49884

merged 1 commit into from
Apr 5, 2025

Conversation

@aramase
Copy link
Member

@aramase aramase commented Feb 24, 2025

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2025
@netlify
Copy link

netlify bot commented Feb 24, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 29dd7e6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67e4a6dc92a3d90008ae7c68

@aramase aramase mentioned this pull request Feb 12, 2025
Open
28 tasks
@netlify
Copy link

netlify bot commented Feb 24, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 29dd7e6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e4a6dc3fff900008de742a
😎 Deploy Preview https://deploy-preview-49884--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rayandas
Copy link
Member

rayandas commented Mar 25, 2025 •
edited
Loading

Hello @aramase 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

@aramase aramase force-pushed the aramase/d/kep_4412_alpha_docs branch from 420c0f4 to 11b95b0 Compare March 25, 2025 23:32
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2025
@aramase aramase marked this pull request as ready for review March 25, 2025 23:33
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 25, 2025
@aramase
Copy link
Member Author

aramase commented Mar 25, 2025

/assign enj liggitt

@aramase aramase force-pushed the aramase/d/kep_4412_alpha_docs branch from 11b95b0 to 8dc510f Compare March 25, 2025 23:41
liggitt
liggitt reviewed Mar 26, 2025
View reviewed changes
@liggitt
Copy link
Member

liggitt commented Mar 26, 2025

looks good overall, just a few suggestions

@aramase aramase force-pushed the aramase/d/kep_4412_alpha_docs branch from 8dc510f to b7b8f59 Compare March 26, 2025 15:21
@aramase aramase requested a review from liggitt March 26, 2025 15:21
@liggitt
Copy link
Member

liggitt commented Mar 26, 2025

lgtm for sig-auth

@aramase aramase force-pushed the aramase/d/kep_4412_alpha_docs branch from b7b8f59 to f1387b0 Compare March 27, 2025 01:15
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2025
@aramase
Add docs for PSAT for Kubelet Image Credential Providers alpha
29dd7e6 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/d/kep_4412_alpha_docs branch from f1387b0 to 29dd7e6 Compare March 27, 2025 01:16
@aramase aramase requested a review from tengqm March 27, 2025 01:16
@aramase
Copy link
Member Author

aramase commented Mar 27, 2025

/assign @tengqm

@rayandas
Copy link
Member

rayandas commented Apr 3, 2025

Hello @aramase 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.
The status of this enhancement is marked as At risk for docs freeze. Thank you!

@aramase
Copy link
Member Author

aramase commented Apr 3, 2025

Hello @aramase 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as At risk for docs freeze. Thank you!

@rayandas I have a lgtm from sig-auth changes (#49884 (comment)), waiting for lgtm + approve from the docs team.

@tengqm
Copy link
Contributor

tengqm commented Apr 5, 2025

Upstream code changes seem complete. Technical LGTM.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 5, 2025

LGTM label has been added.

Git tree hash: 9e4e874c4e42b06e919fd9fcc763be6b6d0c2124

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 53b7bf9 into kubernetes:dev-1.33 Apr 5, 2025
6 checks passed
@aramase aramase deleted the aramase/d/kep_4412_alpha_docs branch April 5, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Princesso Princesso Awaiting requested review from Princesso

@liggitt liggitt Awaiting requested review from liggitt

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@liggitt liggitt

@tengqm tengqm

@enj enj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aramase @rayandas @liggitt @tengqm @k8s-ci-robot @enj