Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pl] fix the interactive Katacoda issue #50053

Merged

Conversation

dkarczmarski
Copy link
Contributor

This is the fix for:
Umbrella issue: Remove tutorials that rely on Katacoda for all localized documents #41496

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/localization General issues or PRs related to localization language/pl Issues or PRs related to Polish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 10, 2025
Copy link

netlify bot commented Mar 10, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 34e2d88
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67ce9d324515a10008b174d0
😎 Deploy Preview https://deploy-preview-50053--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dkarczmarski dkarczmarski reopened this Mar 10, 2025
@mfilocha mfilocha self-assigned this Mar 10, 2025
@mfilocha
Copy link
Contributor

@dkarczmarski I think this PR shouldn't be on renaming files to -gone: https://github.com/kubernetes/website/blob/main/content/en/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive-gone.html

We should update cluster-intro.html to match upstream English content and simply remove cluster-interactive.html. And a similar way for remaining files.

@dkarczmarski
Copy link
Contributor Author

@dkarczmarski I think this PR shouldn't be on renaming files to -gone: https://github.com/kubernetes/website/blob/main/content/en/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive-gone.html

We should update cluster-intro.html to match upstream English content and simply remove cluster-interactive.html. And a similar way for remaining files.

yes. you are right.

so, additionally :

  • I removed all interactive files.
  • I removed all references to these files.
  • I changed sentences that are about "online tutorial" / "interactive tutorial".

it is not a perfect solution, but for now, it fixes the main issue with katacoda .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 18: link href="/docs/tutorials/kubernetes-basics/public/css/styles.css" ... doesn't exist un upstream version anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing lines 36 and 93 from the upstream English version. Also, style line should be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes here compared to the upstream version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes here compared to the upstream version
@mfilocha
yes. that is true. but this PR is a solution only for the katacoda issue . it is not full update to the upsteam english version.

it requaires more time to do the full update , so i will do in the future, but it is only a temporary solution for the katacode ussue because it doesn't work and this solution is better than nothing :)

how do you think ? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, please create a new PR for remaining changes.

@mfilocha
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4623f3a718ba1b4b8b0f00cab8e0b636adcf985b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfilocha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit c40fe7e into kubernetes:main Mar 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pl Issues or PRs related to Polish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants