-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pl] fix the interactive Katacoda issue #50053
[pl] fix the interactive Katacoda issue #50053
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@dkarczmarski I think this PR shouldn't be on renaming files to -gone: https://github.com/kubernetes/website/blob/main/content/en/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive-gone.html We should update |
yes. you are right. so, additionally :
it is not a perfect solution, but for now, it fixes the main issue with katacoda . |
804af75
to
34e2d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 18: link href="/docs/tutorials/kubernetes-basics/public/css/styles.css" ... doesn't exist un upstream version anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing lines 36 and 93 from the upstream English version. Also, style line should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of changes here compared to the upstream version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of changes here compared to the upstream version
@mfilocha
yes. that is true. but this PR is a solution only for the katacoda issue . it is not full update to the upsteam english version.
it requaires more time to do the full update , so i will do in the future, but it is only a temporary solution for the katacode ussue because it doesn't work and this solution is better than nothing :)
how do you think ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, please create a new PR for remaining changes.
/lgtm |
LGTM label has been added. Git tree hash: 4623f3a718ba1b4b8b0f00cab8e0b636adcf985b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfilocha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the fix for:
Umbrella issue: Remove tutorials that rely on Katacoda for all localized documents #41496