Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highly-available-master.md #5006

Merged
merged 2 commits into from
Aug 24, 2017
Merged

Conversation

hanxiaoshuai
Copy link
Contributor

@hanxiaoshuai hanxiaoshuai commented Aug 17, 2017

modify "all master" to "all masters"


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 17, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 17, 2017

Deploy preview ready!

Built with commit bcfd906

https://deploy-preview-5006--kubernetes-io-master-staging.netlify.com

Copy link
Contributor

@jesscodez jesscodez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small fix needed

@@ -92,11 +92,11 @@ $ KUBE_GCE_ZONE=replica-zone KUBE_REPLICATE_EXISTING_MASTER=true ./cluster/kube-

## Best practices for replicating masters for HA clusters

* Try to place masters replicas in different zones. During a zone failure, all master placed inside the zone will fail.
* Try to place masters replicas in different zones. During a zone failure, all masters placed inside the zone will fail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also change "masters replicas" to "master replicas" while we're here? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,good suggestion

@jesscodez
Copy link
Contributor

LGTM

@jesscodez jesscodez merged commit e8029bd into kubernetes:master Aug 24, 2017
chenopis added a commit that referenced this pull request Aug 24, 2017
…hub.io into chenopis-glossary-project

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (53 commits)
  command name style
  Update ingress.md
  Update install-kubectl.md
  Update highly-available-master.md (#5006)
  Update ip-masq-agent.md
  Update declare-network-policy.md
  Move mungedocs tool to the docs repo. (#5178)
  Update managing-tls-in-a-cluster.md (#5101)
  Update kubeconfig topics. (#4439)
  Update kube-proxy.md (#5051)
  Update rollback-daemon-set.md (#5068)
  Update access-cluster.md (#5078)
  Uppercase first letter of the words (#5084)
  Uppercase first letter (#5085)
  Update out-of-resource.md (#5087)
  Update labels.md (#5089)
  Update index.md (#5092)
  Update nodes.md (#5094)
  Update force-delete-stateful-set-pod.md (#5095)
  Update disruptions.md (#5098)
  ...
jesscodez pushed a commit that referenced this pull request Sep 22, 2017
* Update highly-available-master.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants