Skip to content

Conversation

@rata
Copy link
Member

@rata rata commented Jul 1, 2025

Description

The code changes for this are:
* github.com/kubernetes/kubernetes#132868
* github.com/kubernetes/kubernetes#132902

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2025
@rata rata changed the base branch from main to dev-1.34 July 1, 2025 13:21
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2025
@netlify
Copy link

netlify bot commented Jul 1, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit f3a6e8e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/687f9de329e3980008e7bc0b

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization language/bn Issues or PRs related to Bengali language language/es Issues or PRs related to Spanish language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 1, 2025
@rata
Copy link
Member Author

rata commented Jul 1, 2025

Grr, I was based on main instead of the dev branch at first, and the lang labels are not going away. Let's wait to see if they are removed by the bot

@dipesh-rawat
Copy link
Member

/remove-area localization blog
/remove-language bn es hi id ja ko pt zh

@k8s-ci-robot k8s-ci-robot removed area/localization General issues or PRs related to localization area/blog Issues or PRs related to the Kubernetes Blog subproject language/bn Issues or PRs related to Bengali language labels Jul 1, 2025
@k8s-ci-robot k8s-ci-robot removed language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language labels Jul 1, 2025
@netlify
Copy link

netlify bot commented Jul 1, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7439eea
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6863e0c9adc9d20008201e05
😎 Deploy Preview https://deploy-preview-51459--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2025
@rata
Copy link
Member Author

rata commented Jul 22, 2025

Pushed the doc changes for this release, this is ready for review :)

@rata
Copy link
Member Author

rata commented Jul 22, 2025

Build is failing, but unrelated to this PR:

4:03:41 PM: "LS0t***" detected as a likely secret:
4:03:41 PM:   found value at line 373 in content/en/docs/tutorials/services/connect-applications-service.md
4:03:41 PM:   found value at line 374 in content/en/docs/tutorials/services/connect-applications-service.md
...
4:03:41 PM:   Error message
4:03:41 PM:   Secrets scanning found secrets in build.

@rata
Copy link
Member Author

rata commented Jul 22, 2025

cc @giuseppe @haircommander

The code changes for this are:
	* github.com/kubernetes/kubernetes/pull/132868
	* github.com/kubernetes/kubernetes/pull/132902

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
@netlify
Copy link

netlify bot commented Jul 22, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f3a6e8e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/687f9de32e990700083dbe77
😎 Deploy Preview https://deploy-preview-51459--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rata
Copy link
Member Author

rata commented Jul 22, 2025

Rebased and that fixed the build :)

@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: b463a15abd4f93273475e1e02fd057cbd7bfaf18

@michellengnx
Copy link
Contributor

Hello @rata 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@rata
Copy link
Member Author

rata commented Aug 5, 2025

@michellengnx can you help me have the docs team review this? The PR is ready for review before the deadline and it has a technical lgtm by @haircommander. I'm waiting for a review from the docs team. Is there something else I should do?

@michellengnx
Copy link
Contributor

/assign @katcosgrove

@reylejano
Copy link
Member

/milestone 1.34

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Aug 6, 2025
@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4ed6a11 into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
@rata rata deleted the userns-134 branch August 6, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants