Skip to content

KEP-3751 VolumeAttributesClass GA in 1.34 Doc Update #51726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

KEP-3751 VolumeAttributesClass GA in 1.34 Doc Update #51726

merged 1 commit into from
Aug 5, 2025

Conversation

@sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Jul 29, 2025

Description

Doc update for VAC GA in 1.34

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jul 29, 2025
@k8s-ci-robot k8s-ci-robot requested a review from reylejano July 29, 2025 18:03
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2025
@xing-yang
Copy link
Contributor

xing-yang commented Jul 29, 2025

I think this should be submitted to dev-1.34.

@sunnylovestiramisu sunnylovestiramisu changed the base branch from main to dev-1.34 July 29, 2025 18:05
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 29, 2025
@netlify
Copy link

netlify bot commented Jul 29, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2d15dba
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6890f375d128dc000861b732

@xing-yang
Copy link
Contributor

xing-yang commented Jul 29, 2025

The change looks good to me, but CI failed.

torredil
torredil reviewed Jul 29, 2025
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates/VolumeAttributesClass.md Outdated
defaultValue: false
fromVersion: "1.31"
toVersion: "1.33"
- stage: ga
Copy link
Member

@torredil torredil Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ga -> stable will fix the build:

2:10:24 PM: ERROR Invalid 'stage' value 'ga' specified for feature gate 'VolumeAttributesClass' in en/docs/reference/command-line-tools-reference/feature-gates/VolumeAttributesClass.md (Valid values are: [alpha beta stable deprecated])

Copy link
Contributor Author

@sunnylovestiramisu sunnylovestiramisu Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, updated.

@netlify
Copy link

netlify bot commented Jul 29, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d15dba
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6890f375a982f200086fec46
😎 Deploy Preview https://deploy-preview-51726--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xing-yang
Copy link
Contributor

xing-yang commented Jul 30, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 30, 2025

LGTM label has been added.

Git tree hash: c331c328879364d15e094541c2a0e62e93e3de6d

@carlory
Copy link
Member

carlory commented Jul 30, 2025

Please also update this link if needed https://kubernetes.io/docs/concepts/storage/volume-attributes-classes/

@carlory
Copy link
Member

carlory commented Jul 30, 2025

Please tell users the feature-gate can be disabled by themselves.

@sunnylovestiramisu
Copy link
Contributor Author

sunnylovestiramisu commented Jul 30, 2025

Please tell users the feature-gate can be disabled by themselves.

Should we add this to the vac page or just the blog post, because it means we need to come back modify it after 1.35

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@k8s-ci-robot k8s-ci-robot requested a review from xing-yang July 30, 2025 18:23
@sunnylovestiramisu
Copy link
Contributor Author

sunnylovestiramisu commented Jul 30, 2025

@carlory Added the wording of disabling it for 1.34

@lmktfy
Copy link
Member

lmktfy commented Jul 30, 2025

When feature gates become locked to true, we should update the metadata in this repo to reflect that.

@sunnylovestiramisu
Copy link
Contributor Author

sunnylovestiramisu commented Jul 30, 2025

It should be locked to true in 1.35

@carlory
Copy link
Member

carlory commented Jul 31, 2025 •
edited
Loading

The page uses beta version to show the volume attributes class. Do we want to switch it to the stable version when the sidecar is released?

@sunnylovestiramisu
Copy link
Contributor Author

sunnylovestiramisu commented Jul 31, 2025 •
edited
Loading

The page uses beta version to show the volume attributes class. Do we want to switch it to the stable version when the sidecar is released?

Yes, but we can do it afterwards instead of this doc freeze? I was thinking we can always update the CSI doc content afterwards which gives us flexibility.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2025
@xing-yang
Copy link
Contributor

xing-yang commented Jul 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 31, 2025

LGTM label has been added.

Git tree hash: d3236837780b4adc42806bdeeb5da712173ed85e

@carlory
Copy link
Member

carlory commented Aug 1, 2025

/lgtm

lmktfy
lmktfy reviewed Aug 2, 2025
View reviewed changes
Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically don't write "please" in our docs, and because this is targeting GA, I'm going to recommend we find another way to suggest that—nicely.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2025
@k8s-ci-robot k8s-ci-robot requested a review from carlory August 4, 2025 17:52
@sunnylovestiramisu
Copy link
Contributor Author

sunnylovestiramisu commented Aug 4, 2025

Removed the "please"

@xing-yang
Copy link
Contributor

xing-yang commented Aug 4, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 4, 2025

LGTM label has been added.

Git tree hash: 0cb0a5448e44215212832191b1e840dd5faa5306

@natalisucks
Copy link
Contributor

natalisucks commented Aug 5, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 17d75d4 into kubernetes:dev-1.34 Aug 5, 2025
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmktfy lmktfy lmktfy left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@reylejano reylejano Awaiting requested review from reylejano

@xing-yang xing-yang Awaiting requested review from xing-yang

@carlory carlory Awaiting requested review from carlory

+1 more reviewer

@torredil torredil torredil left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@xing-yang xing-yang

@carlory carlory

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

1.34

Development

Successfully merging this pull request may close these issues.

7 participants

@sunnylovestiramisu @xing-yang @k8s-ci-robot @carlory @lmktfy @natalisucks @torredil