Skip to content

Conversation

@aramase
Copy link
Member

@aramase aramase commented Jul 29, 2025

Doc update for egress selector support in jwt authenticator: https://git.k8s.io/enhancements/keps/sig-auth/3331-structured-authentication-configuration
KEP issue: kubernetes/enhancements#3331
Implementation PR: kubernetes/kubernetes#132768

/triage accepted
/sig auth
/assign enj liggitt

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 29, 2025
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Jul 29, 2025
@netlify
Copy link

netlify bot commented Jul 29, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5c7df0c
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/688b9ca59a37370008b26a11

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 29, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2025
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one question about whether to include the feature-state / gate name in the doc

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/d/authn_egress_selector branch from 9b15456 to 9910b9b Compare July 29, 2025 20:36
@netlify
Copy link

netlify bot commented Jul 29, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9b15456
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68892eee28a0ef0008590979
😎 Deploy Preview https://deploy-preview-51728--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aramase aramase requested a review from liggitt July 29, 2025 20:38
@liggitt
Copy link
Member

liggitt commented Jul 29, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 552c3287b2e2231aad2929b86b4b291aa35fdcd5

@netlify
Copy link

netlify bot commented Jul 29, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5c7df0c
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/688b9ca5503297000830161c
😎 Deploy Preview https://deploy-preview-51728--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@enj enj moved this to Needs Triage in SIG Auth Jul 30, 2025
@enj enj added this to SIG Auth Jul 30, 2025
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2025
@k8s-ci-robot k8s-ci-robot requested a review from enj July 31, 2025 16:41
@aramase
Copy link
Member Author

aramase commented Jul 31, 2025

/assign @dipesh-rawat
/cc liggitt (for another lgtm)

@aramase aramase requested a review from dipesh-rawat August 1, 2025 16:46
@liggitt
Copy link
Member

liggitt commented Aug 2, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d33f6ce76d0c1f4bebcf11f3860a3a2157ae23ac

@aramase aramase moved this from Needs Triage to In Review in SIG Auth Aug 4, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit c6a82b4 into kubernetes:dev-1.34 Aug 5, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Aug 5, 2025
@aramase aramase deleted the aramase/d/authn_egress_selector branch August 5, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants