-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add stub reference for KYAML #52583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stub reference for KYAML #52583
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/retitle [WIP] KYAML reference placeholder |
|
/milestone 1.35 |
20c76f6 to
647d12a
Compare
|
CC: @thockin |
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments
|
@rxinui is it still WIP, or this is ready for finalization? |
5370f0d to
a4520eb
Compare
f8fbca0 to
dd4b9ac
Compare
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback
064785e to
6d5f559
Compare
I wholeheartedly disagree with this statement, we don't need full reference for beta promotion. As @thockin pointed out we can document main bits, but we shouldn't be super prescriptive about it's actual contents, other than just stressing the fact that kyaml is just a subset of yaml. |
|
@soltysh, here's the problem. When we enable features by default, we (SIG Docs, mainly) ideally want GA quality explanations of those features. For beta we are usually willing to overlook snags, typos, missing details - and we'll try to get those covered before actual GA. Here's the current KYAML documentation, such as it is. This is not close to GA quality. It's really not. And we can't rely on external explanations like we do for YAML or JSON because KYAML is a Kubernetes thing. Do we need to finish the documentation? No. If we can't do that, I do think that waiting an extra minor release is a better default. It makes people ask for an exception (which might well be granted), and I do think that extra effort to get the exception is a good thing for end users. If we didn't have it, many more things might go enabled-by-default without documentation; if we make a precedent that you don't even need to ask for an exception, people won't. So, my judgement is that this needs either:
I didn't LGTM this PR as-is, and that's because it's technically not correct, to the point of being misleading. @rxinui I am sure you had a good intent here – but we do aim for GA quality and this PR isn't close enough to convince me. Just to reiterate: when things go enabled by default, even if you can turn them off, we aim to have GA quality docs. I don't think I've LGTMed any docs for a beta feature where the docs didn't pass technical scrutiny (I'd accept something like a typo in Kuberentes, but even then I'll typically file a good-first-issue to get it fixed). |
|
/hold Before we merge this, I want SIG Docs to be confident that my earlier concerns are addressed. Especially see #52583 (comment) OK to unhold if any of I, the release docs team, or SIG Docs leadership are satisfied we've thought this through and the docs are good enough. |
|
So I'm personally leaning towards:
which means we'd add a sub-section, for example under https://kubernetes.io/docs/reference/kubectl/#syntax-1 where we'd explain what kyaml is, and in the followup, but before GA we'll work on having more explanatory page, but just like @thockin mentioned earlier not a full reference, but rather an explanation of key differences from the yaml, which make the kyaml special. |
|
No problem, I'm working towards the optimal result. I have not rework my PR as I had few bandwidth lately but I will certainly apply all your recommendations above. |
Just finished chatting on slack with @lmktfy and we both agreed that we'll want entirely new page, just the contents should be short explaining in a single paragraph what kyaml is. In the future we'll work on expanding it. |
Signed-off-by: rxinui <rainui.ly@gmail.com>
|
/label tide/merge-method-squash |
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: bf9a077a130615143617392170a0a8c448928b93
|
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there. I plan to commit the fixes and merge it.
Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we'll follow this up with a PR that updates https://kubernetes.io/docs/reference/ to hyperlink to https://kubernetes.io/docs/reference/encodings/
|
/hold cancel |
|
LGTM label has been added. Git tree hash: 7a0f909052fd4e7ad0330177996480fa0eef844b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| card: | ||
| name: encodings | ||
| title: Kubernetes encodings | ||
| weight: 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) I'd set a bigger number. This influences the ordering on https://k8s.io/docs/home/ BTW
|
Thanks all, I was not tracking this closely enough. |
Description
As requested here by @lmktfy - this PR
serves as a placeholder andaims to provide KYAML supports reference.Issue
Linked to #52523 (review)