Skip to content

Conversation

@rxinui
Copy link

@rxinui rxinui commented Sep 29, 2025

Description

As requested here by @lmktfy - this PR serves as a placeholder and aims to provide KYAML supports reference.

Issue

Linked to #52523 (review)

@netlify
Copy link

netlify bot commented Sep 29, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2af5887
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/691f5ed413e31c0008baba72

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2025
@netlify
Copy link

netlify bot commented Sep 29, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 40c8adb
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/691f5e8d21b14d00089527ec
😎 Deploy Preview https://deploy-preview-52583--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rxinui
Copy link
Author

rxinui commented Sep 29, 2025

cc: @lmktfy @soltysh

@lmktfy
Copy link
Member

lmktfy commented Sep 29, 2025

/retitle [WIP] KYAML reference placeholder

@k8s-ci-robot k8s-ci-robot changed the title Kyaml placeholder [WIP] KYAML reference placeholder Sep 29, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025
@lmktfy
Copy link
Member

lmktfy commented Sep 29, 2025

/milestone 1.35

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Sep 29, 2025
@soltysh soltysh mentioned this pull request Oct 1, 2025
15 tasks
@rxinui rxinui force-pushed the kyaml-placeholder branch from 20c76f6 to 647d12a Compare October 29, 2025 13:43
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2025
@rxinui
Copy link
Author

rxinui commented Oct 29, 2025

CC: @thockin

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

@soltysh
Copy link
Contributor

soltysh commented Oct 30, 2025

@rxinui is it still WIP, or this is ready for finalization?

@rxinui rxinui force-pushed the kyaml-placeholder branch from 5370f0d to a4520eb Compare October 30, 2025 11:23
@rxinui rxinui changed the title [WIP] KYAML reference placeholder KYAML reference placeholder Oct 30, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@rxinui
Copy link
Author

rxinui commented Oct 30, 2025

It is now ready @soltysh @lmktfy

No longer WIP.

@rxinui rxinui force-pushed the kyaml-placeholder branch 3 times, most recently from f8fbca0 to dd4b9ac Compare October 30, 2025 14:03
Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback

@rxinui rxinui force-pushed the kyaml-placeholder branch from 064785e to 6d5f559 Compare October 30, 2025 14:13
@soltysh
Copy link
Contributor

soltysh commented Nov 20, 2025

If we don't improve the KYAML docs by the docs freeze deadline, my advice is to revert the promotion to beta for v1.35
Giving it one more minor release before beta would be OK by me.

I wholeheartedly disagree with this statement, we don't need full reference for beta promotion. As @thockin pointed out we can document main bits, but we shouldn't be super prescriptive about it's actual contents, other than just stressing the fact that kyaml is just a subset of yaml.

@lmktfy
Copy link
Member

lmktfy commented Nov 20, 2025

@soltysh, here's the problem.

When we enable features by default, we (SIG Docs, mainly) ideally want GA quality explanations of those features. For beta we are usually willing to overlook snags, typos, missing details - and we'll try to get those covered before actual GA.

Here's the current KYAML documentation, such as it is.
https://kubernetes.io/docs/reference/kubectl/#syntax-1

This is not close to GA quality. It's really not. And we can't rely on external explanations like we do for YAML or JSON because KYAML is a Kubernetes thing.

Do we need to finish the documentation? No.
Do we need more than we have at alpha? I think yes. At the very least, I'd expect a heading and some explanation. A stub page is fine.

If we can't do that, I do think that waiting an extra minor release is a better default. It makes people ask for an exception (which might well be granted), and I do think that extra effort to get the exception is a good thing for end users. If we didn't have it, many more things might go enabled-by-default without documentation; if we make a precedent that you don't even need to ask for an exception, people won't.


So, my judgement is that this needs either:

  • a (correct) stub page about what KYAML is
    • or a subsection in some existing page, maybe
    • that's tricky because the obvious place to put it would be our "YAML" page, and we don't have one
  • an exception

I didn't LGTM this PR as-is, and that's because it's technically not correct, to the point of being misleading. @rxinui I am sure you had a good intent here – but we do aim for GA quality and this PR isn't close enough to convince me. Just to reiterate: when things go enabled by default, even if you can turn them off, we aim to have GA quality docs. I don't think I've LGTMed any docs for a beta feature where the docs didn't pass technical scrutiny (I'd accept something like a typo in Kuberentes, but even then I'll typically file a good-first-issue to get it fixed).

@lmktfy
Copy link
Member

lmktfy commented Nov 20, 2025

/hold

Before we merge this, I want SIG Docs to be confident that my earlier concerns are addressed. Especially see #52583 (comment)

OK to unhold if any of I, the release docs team, or SIG Docs leadership are satisfied we've thought this through and the docs are good enough.

@soltysh
Copy link
Contributor

soltysh commented Nov 20, 2025

So I'm personally leaning towards:

  • a (correct) stub page about what KYAML is
    • or a subsection in some existing page, maybe
    • that's tricky because the obvious place to put it would be our "YAML" page, and we don't have one

which means we'd add a sub-section, for example under https://kubernetes.io/docs/reference/kubectl/#syntax-1 where we'd explain what kyaml is, and in the followup, but before GA we'll work on having more explanatory page, but just like @thockin mentioned earlier not a full reference, but rather an explanation of key differences from the yaml, which make the kyaml special.

@rxinui
Copy link
Author

rxinui commented Nov 20, 2025

No problem, I'm working towards the optimal result. I have not rework my PR as I had few bandwidth lately but I will certainly apply all your recommendations above.

@soltysh
Copy link
Contributor

soltysh commented Nov 20, 2025

No problem, I'm working towards the optimal result. I have not rework my PR as I had few bandwidth lately but I will certainly apply all your recommendations above.

Just finished chatting on slack with @lmktfy and we both agreed that we'll want entirely new page, just the contents should be short explaining in a single paragraph what kyaml is. In the future we'll work on expanding it.

Signed-off-by: rxinui <rainui.ly@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2025
@soltysh
Copy link
Contributor

soltysh commented Nov 20, 2025

/label tide/merge-method-squash

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bf9a077a130615143617392170a0a8c448928b93

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there. I plan to commit the fixes and merge it.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
rxinui and others added 2 commits November 20, 2025 19:32
Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
Co-authored-by: Tim Bannister <193443691+lmktfy@users.noreply.github.com>
Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we'll follow this up with a PR that updates https://kubernetes.io/docs/reference/ to hyperlink to https://kubernetes.io/docs/reference/encodings/

@lmktfy
Copy link
Member

lmktfy commented Nov 20, 2025

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a0f909052fd4e7ad0330177996480fa0eef844b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

card:
name: encodings
title: Kubernetes encodings
weight: 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) I'd set a bigger number. This influences the ordering on https://k8s.io/docs/home/ BTW

@k8s-ci-robot k8s-ci-robot merged commit 048ea42 into kubernetes:dev-1.35 Nov 20, 2025
2 checks passed
@thockin
Copy link
Member

thockin commented Nov 22, 2025

Thanks all, I was not tracking this closely enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants