KEP-5471: Add docs for extend tolerations for alpha #52824

helayoty · 2025-10-20T22:21:18Z

Description

Update docs for extend tolerations operators, Gt and Lt, for graduation to alpha.

Issue

KEP Issue: link
KEP: link

/sig scheduling

Issue

Closes: #

netlify · 2025-10-20T22:21:25Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`ded370a`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/691cbc3a68ce6d0008f8a9f6

k8s-ci-robot · 2025-10-20T22:21:25Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2025-10-20T22:30:55Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`ded370a`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/691cbc3a4b2640000805fa4b
😎 Deploy Preview	https://deploy-preview-52824--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

lmktfy

Thanks for the PR.

I know this is a draft, but I want to provide some early feedback. I am concerned that it might not be right for our docs once you finish it, and I hope that the early feedback helps you to find the right way to tweak it.

content/en/docs/concepts/scheduling-eviction/taint-and-toleration.md

...s/reference/command-line-tools-reference/feature-gates/TaintTolerationComparisonOperators.md

content/en/examples/pods/pod-with-numeric-toleration.yaml

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

helayoty · 2025-10-22T03:00:19Z

@lmktfy Many thanks for the early feedback. Addressed all and appreciate if you have time for another round.

Urvashi0109 · 2025-11-17T08:20:06Z

Hello @helayoty 👋, v1.35 Docs Team here again!

We are closing in on the deadline to get your PR ready for review before Tuesday 18th November 2025, so I'm sending a second reminder. Please take a look at the Documenting for a release - PR Ready for Review document to get your PR ready for review before the deadline.

Please also let us know once your PR is fully Ready for Review -- meaning all documentation updates are complete and it's awaiting reviewer feedback -- so we can update our tracking.

Thank you!

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

helayoty · 2025-11-18T04:47:07Z

Please also let us know once your PR is fully Ready for Review -- meaning all documentation updates are complete and it's awaiting reviewer feedback -- so we can update our tracking.

@Urvashi0109 , PR is ready for review.

tengqm · 2025-11-18T07:50:17Z

content/en/docs/concepts/scheduling-eviction/taint-and-toleration.md


-For numeric operators, both the toleration and taint values must be valid integers.
-If either value cannot be parsed as an integer, the toleration does not match.
+For numeric operators, both the toleration and taint values must be valid integers. If either value cannot be parsed as an integer, the toleration does not match.


Why change this?
We encourage wrapping long "lines" for ease of reading and maintenance.

tengqm · 2025-11-18T07:51:17Z

content/en/docs/concepts/scheduling-eviction/taint-and-toleration.md

-validates that the toleration values are valid integers. Taint values on nodes are not
-validated at node registration time. If a node has a non-numeric taint value
-(for example, `servicelevel.organization.example/agreed-service-level=high:NoSchedule`), pods with numeric comparison
+When you create a Pod that uses `Gt` or `Lt` tolerations operators, the API server validates that the toleration values are valid integers. Taint values on nodes are not validated at node registration time. If a node has a non-numeric taint value (for example, `servicelevel.organization.example/agreed-service-level=high:NoSchedule`), pods with numeric comparison


Please check https://sembr.org/ for the convention we prefer.

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

sayanchowdhury · 2025-11-21T16:17:34Z

Hello @helayoty 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 3rd December 2025, 12:00 UTC.

This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

lmktfy · 2025-11-21T17:44:10Z

content/en/docs/concepts/scheduling-eviction/taint-and-toleration.md

+registration time. If a node has a non-numeric taint value (for example,
+`servicelevel.organization.example/agreed-service-level=high:NoSchedule`),
+pods with numeric comparison operators will not match that taint and cannot schedule on that node.
+{{< /note >}}


nit: could mention that people can use admission-time checks to block node registrations with invalid taints.

It's a very strict choice but you can do it if you need to.

lmktfy · 2025-11-21T17:45:01Z

content/en/docs/concepts/scheduling-eviction/taint-and-toleration.md

-  * Pods that do not tolerate the taint are evicted immediately
-  * Pods that tolerate the taint without specifying `tolerationSeconds` in
+
+* Pods that do not tolerate the taint are evicted immediately


Why the indentation change,?

k8s-ci-robot added this to the 1.35 milestone Oct 20, 2025

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Oct 20, 2025

github-project-automation bot added this to SIG Scheduling and SIG Apps Oct 20, 2025

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2025

k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 20, 2025

k8s-ci-robot requested review from bsalamat and dipesh-rawat October 20, 2025 22:21

github-project-automation bot moved this to Needs Triage in SIG Apps Oct 20, 2025

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2025

helayoty mentioned this pull request Oct 20, 2025

Extended Toleration Operators for Threshold-Based Placement kubernetes/enhancements#5471

Open

7 tasks

Add docs for extended tolerations operators

b12c545

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

helayoty force-pushed the helayoty/5471-extend-tolerations-alpha branch from b19d7a4 to b12c545 Compare October 20, 2025 22:32

lmktfy reviewed Oct 20, 2025

View reviewed changes

address review feedback

ad6f69e

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

helayoty requested a review from lmktfy October 22, 2025 02:59

helayoty moved this to Backlog in SIG Scheduling Oct 22, 2025

helayoty marked this pull request as ready for review November 17, 2025 18:22

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2025

k8s-ci-robot requested a review from divya-mohan0209 November 17, 2025 18:22

helayoty moved this from Backlog to Needs Review in SIG Scheduling Nov 18, 2025

add final updates

57a6ba4

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

tengqm reviewed Nov 18, 2025

View reviewed changes

apply sembr lint

ded370a

Signed-off-by: Heba Elayoty <heelayot@microsoft.com>

helayoty requested a review from tengqm November 18, 2025 18:35

lmktfy reviewed Nov 21, 2025

View reviewed changes

helayoty requested a review from lmktfy November 24, 2025 15:59

KEP-5471: Add docs for extend tolerations for alpha #52824

Are you sure you want to change the base?

KEP-5471: Add docs for extend tolerations for alpha #52824

Conversation

helayoty commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue

Issue

Uh oh!

netlify bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Uh oh!

k8s-ci-robot commented Oct 20, 2025

Uh oh!

netlify bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

lmktfy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

helayoty commented Oct 22, 2025

Uh oh!

Urvashi0109 commented Nov 17, 2025

Uh oh!

helayoty commented Nov 18, 2025

Uh oh!

tengqm Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

helayoty Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

tengqm Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

helayoty Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

sayanchowdhury commented Nov 21, 2025

Uh oh!

lmktfy Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmktfy Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

helayoty commented Oct 20, 2025 •

edited

Loading

netlify bot commented Oct 20, 2025 •

edited

Loading

netlify bot commented Oct 20, 2025 •

edited

Loading

lmktfy Nov 21, 2025 •

edited

Loading