Skip to content

Conversation

@dkarczmarski
Copy link
Member

fix broken links to the kubernetes-examples repo

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language labels Oct 31, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2025
@netlify
Copy link

netlify bot commented Oct 31, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 11f3b78
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/690b56e81d296e00087c4405
😎 Deploy Preview https://deploy-preview-53020--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@Gauravpadam Gauravpadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dkarczmarski for the contribution!

Other than the blog edit, LGTM for the rest of changes

@dkarczmarski dkarczmarski force-pushed the fix-broken-link-to-examples branch from dc92cd5 to 9072173 Compare October 31, 2025 08:18
@dkarczmarski
Copy link
Member Author

Thanks @dkarczmarski for the contribution!

Other than the blog edit, LGTM for the rest of changes

@Gauravpadam
ok. I removed that change for that file :)

@Gauravpadam
Copy link
Member

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh I noticed you originally archived these kubernetes/examples (as part of kubernetes/examples@8b3fa9a) and wanted to get your take. Do you think we should update the links, or remove them from the docs entirely because they’re no longer supported?
Thanks, and apologies for the ping!

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than link to archived content, we should remove the links.

@dkarczmarski would you be willing to do that instead?

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@lmktfy
Copy link
Member

lmktfy commented Oct 31, 2025

/remove-area blog

@k8s-ci-robot k8s-ci-robot removed the area/blog Issues or PRs related to the Kubernetes Blog subproject label Oct 31, 2025
@dkarczmarski
Copy link
Member Author

Rather than link to archived content, we should remove the links.

@dkarczmarski would you be willing to do that instead?

/lgtm cancel

@lmktfy

I found the PR that moved it to the _archived directory :
kubernetes/examples#564 .
he said :

As discussed in sig-apps meeting on 5/12 we are starting to cleanup this repository.

The initial take is to move all (almost 😉) to _archived/ directory, from where we'll go one by one and try to revive the examples which still work, and over time drop everything else.

so as I understand it, it does not mean that it will be definitely removed, but it might be removed or it might be revived.
so maybe it is better to update the links to '_archived' version for now ? it is easier to update the link than to insert it again after it has been removed. I can open an issue in the 'examples' project and ask them to notify us when the work on '_archived' directory is done.

how do you think ?

@soltysh
Copy link
Contributor

soltysh commented Nov 5, 2025

so as I understand it, it does not mean that it will be definitely removed, but it might be removed or it might be revived.
so maybe it is better to update the links to '_archived' version for now ? it is easier to update the link than to insert it again after it has been removed. I can open an issue in the 'examples' project and ask them to notify us when the work on '_archived' directory is done.

Please do not over interpret my wording. It's moved to _archived on its way to be either fixed or removed. All of the PRs fixing the links in the docs ideally should not be pointing users to broken examples, and the current are just that - broken. So it's better not to have those links available at all. So just like Tim pointed above, please REMOVE the links.

@dkarczmarski
Copy link
Member Author

@soltysh
thank you for your comment. I have no doubts now. I will do just that :)

Co-authored-by: Gaurav Padam <gauravpadam2@gmail.com>
@dkarczmarski dkarczmarski force-pushed the fix-broken-link-to-examples branch from ee87f3c to 11f3b78 Compare November 5, 2025 13:53
@dkarczmarski dkarczmarski changed the title fix broken links to examples remove broken links to examples Nov 5, 2025
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a4fb5e1f3420152e2ad7c6b98a71f991d3733a5

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 13d9b63 into kubernetes:main Nov 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants