-
Notifications
You must be signed in to change notification settings - Fork 15.1k
remove broken links to examples #53020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove broken links to examples #53020
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
content/en/blog/_posts/2016-05-00-Hypernetes-Security-And-Multi-Tenancy-In-Kubernetes.md
Outdated
Show resolved
Hide resolved
Gauravpadam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dkarczmarski for the contribution!
Other than the blog edit, LGTM for the rest of changes
dc92cd5 to
9072173
Compare
@Gauravpadam |
|
/lgtm Thanks! |
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soltysh I noticed you originally archived these kubernetes/examples (as part of kubernetes/examples@8b3fa9a) and wanted to get your take. Do you think we should update the links, or remove them from the docs entirely because they’re no longer supported?
Thanks, and apologies for the ping!
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than link to archived content, we should remove the links.
@dkarczmarski would you be willing to do that instead?
/lgtm cancel
|
/remove-area blog |
I found the PR that moved it to the _archived directory :
so as I understand it, it does not mean that it will be definitely removed, but it might be removed or it might be revived. how do you think ? |
Please do not over interpret my wording. It's moved to |
|
@soltysh |
Co-authored-by: Gaurav Padam <gauravpadam2@gmail.com>
ee87f3c to
11f3b78
Compare
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: 8a4fb5e1f3420152e2ad7c6b98a71f991d3733a5
|
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix broken links to the kubernetes-examples repo