Skip to content

Conversation

@andrewsykim
Copy link
Member

Description

Add docs for new feature PodTopologyLabelsAdmission that will be graduating to Beta and on by default in v1.35

Issue

kubernetes/enhancements#4742

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Nov 6, 2025
@netlify
Copy link

netlify bot commented Nov 6, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5f2da47
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/690fcd408f63cd00082ae1b7

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dom4ha November 6, 2025 19:44
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from macsko November 6, 2025 19:44
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewsykim The PR is currently lacking the change to transition the feature gate PodTopologyLabelsAdmission from Alpha to Beta. The necessary change should be made in the feature gate description file - PodTopologyLabelsAdmission.md (here).

Please refer to the documentation here for further information.


## Pod topology labels

{{< feature-state feature_gate_name="PodTopologyLabelAdmission" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there’s a small typo in the feature gate name, which is causing the build preview to fail.

7:45:37 PM: ERROR Invalid feature gate: 'PodTopologyLabelAdmission' is not recognized or lacks a matching description file in 'en/docs/reference/command-line-tools-reference/feature-gates'

Try below suggestion to help resolve it.

Suggested change
{{< feature-state feature_gate_name="PodTopologyLabelAdmission" >}}
{{< feature-state feature_gate_name="PodTopologyLabelsAdmission" >}}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@andrewsykim andrewsykim force-pushed the pod-topology-labels-1-35 branch from 43271a8 to bd57282 Compare November 7, 2025 01:11
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2025
@netlify
Copy link

netlify bot commented Nov 7, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5f2da47
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/690fcd406ddcd60008166478
😎 Deploy Preview https://deploy-preview-53111--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@andrewsykim andrewsykim force-pushed the pod-topology-labels-1-35 branch from bd57282 to b7a6131 Compare November 8, 2025 01:05

{{< feature-state feature_gate_name="PodTopologyLabelsAdmission" >}}

Pods inherit the topology labels (topology.kubernetes.io/zone and topology.kubernetes.io/region) from their assigned Node if those labels are present. These labels can then be utilized via the Downward API to provide the workload with node topology awareness.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pods inherit the topology labels (topology.kubernetes.io/zone and topology.kubernetes.io/region) from their assigned Node if those labels are present. These labels can then be utilized via the Downward API to provide the workload with node topology awareness.
Pods inherit the topology labels (`topology.kubernetes.io/zone` and `topology.kubernetes.io/region`) from their assigned Node
if those labels are present.
These labels can then be utilized via the Downward API to provide the workload with node topology awareness.

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim andrewsykim force-pushed the pod-topology-labels-1-35 branch from b7a6131 to 5f2da47 Compare November 8, 2025 23:07
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 46c264241c55c44b7b54edf288e3e5c356530e55

@tengqm
Copy link
Contributor

tengqm commented Nov 9, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5df0293 into kubernetes:dev-1.35 Nov 9, 2025
6 checks passed
ghost referenced this pull request Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants