-
Notifications
You must be signed in to change notification settings - Fork 15.1k
add docs for PodTopologyLabelsAdmission feature #53111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs for PodTopologyLabelsAdmission feature #53111
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewsykim The PR is currently lacking the change to transition the feature gate PodTopologyLabelsAdmission from Alpha to Beta. The necessary change should be made in the feature gate description file - PodTopologyLabelsAdmission.md (here).
Please refer to the documentation here for further information.
|
|
||
| ## Pod topology labels | ||
|
|
||
| {{< feature-state feature_gate_name="PodTopologyLabelAdmission" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there’s a small typo in the feature gate name, which is causing the build preview to fail.
7:45:37 PM: ERROR Invalid feature gate: 'PodTopologyLabelAdmission' is not recognized or lacks a matching description file in 'en/docs/reference/command-line-tools-reference/feature-gates'
Try below suggestion to help resolve it.
| {{< feature-state feature_gate_name="PodTopologyLabelAdmission" >}} | |
| {{< feature-state feature_gate_name="PodTopologyLabelsAdmission" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
43271a8 to
bd57282
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
...t/en/docs/reference/command-line-tools-reference/feature-gates/PodTopologyLabelsAdmission.md
Show resolved
Hide resolved
bd57282 to
b7a6131
Compare
|
|
||
| {{< feature-state feature_gate_name="PodTopologyLabelsAdmission" >}} | ||
|
|
||
| Pods inherit the topology labels (topology.kubernetes.io/zone and topology.kubernetes.io/region) from their assigned Node if those labels are present. These labels can then be utilized via the Downward API to provide the workload with node topology awareness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Pods inherit the topology labels (topology.kubernetes.io/zone and topology.kubernetes.io/region) from their assigned Node if those labels are present. These labels can then be utilized via the Downward API to provide the workload with node topology awareness. | |
| Pods inherit the topology labels (`topology.kubernetes.io/zone` and `topology.kubernetes.io/region`) from their assigned Node | |
| if those labels are present. | |
| These labels can then be utilized via the Downward API to provide the workload with node topology awareness. |
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
b7a6131 to
5f2da47
Compare
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
LGTM label has been added. Git tree hash: 46c264241c55c44b7b54edf288e3e5c356530e55
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SergeyKanzhelev, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add docs for new feature PodTopologyLabelsAdmission that will be graduating to Beta and on by default in v1.35
Issue
kubernetes/enhancements#4742
Closes: #