Skip to content

[ko] Update open-a-pr page #53300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ko] Update open-a-pr page #53300

wants to merge 1 commit into from

Conversation

@esunn0412
Copy link

@esunn0412 esunn0412 commented Nov 18, 2025

Description

This PR updates the Korean document of the contribute/new-content/open-a-pr page.
The changes generally include:

  • Translating outdated English text to Korean
  • Improving sentence consistency
    • these include:
      • 저장소 -> 리포지터리
      • 업스트림 → upstream
      • 편집기 → 에디터
  • Fixing formatting within tab sections

Issue

This PR addresses a current open issue: #53263

Closes: #53263

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 18, 2025 •
edited
Loading

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: esunn0412 / name: Taeeun Kim (1119868)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 18, 2025

Welcome @esunn0412!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 18, 2025
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Nov 18, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jihoon-seo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 18, 2025
@netlify
Copy link

netlify bot commented Nov 18, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1119868
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/691cc5ff7b38f7000801483e
😎 Deploy Preview https://deploy-preview-53300--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Eundms
Copy link
Member

Eundms commented Nov 18, 2025

/assign

Eundms
Eundms reviewed Nov 21, 2025
View reviewed changes
Copy link
Member

@Eundms Eundms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esunn0412

Thank you for your first contribution!

I left a few review comments, mainly regarding naturalness of the translation and consistency with previously used Korean terminology in the Kubernetes docs.

  • Title Format (Recommended)
    Please change the Issue/PR title to:
    [ko] Update /contribute/new-content/open-a-pr.md
    Mentioning the file path makes it easier to find related or previous PRs/issues.

  • Update Translation (Recommended)
    Please review and update not only the modified lines, but also the surrounding previous lines for consistency.

content/ko/docs/contribute/new-content/open-a-pr.md
도 사용하지 않는다. 이 키워드들은 나중에 풀 리퀘스트 설명에 추가할 수 있다.
{{< /note >}}

1. **Propose file change**를 선택한다.
Copy link
Member

@Eundms Eundms Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. **Propose changes**를 선택한다.
  • 원문과 동일하게 바꾸었습니다.

content/ko/docs/contribute/new-content/open-a-pr.md

1. **Propose file change**를 선택한다.

1. **Create pull requests**를 선택한다.
Copy link
Member

@Eundms Eundms Nov 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. **Create pull request**를 선택한다.
  • 원문과 동일하게 바꾸었습니다.

content/ko/docs/contribute/new-content/open-a-pr.md
```

1. 터미널에서, 쿠버네티스 웹사이트 리퍼지토리로 이동한 뒤 Hugo 서버를 실행한다.
1. 터미널에서, 쿠버네티스 website 리퍼지토리로 이동한 뒤 Hugo 서버를 실행한다.
Copy link
Member

@Eundms Eundms Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. 터미널에서, 쿠버네티스 website 리퍼지토리로 이동한 뒤 Hugo 서버를 실행한다.
1. 터미널에서, 쿠버네티스 website 리포지터리로 이동한 뒤 Hugo 서버를 실행한다.
  • 오타를 수정하였습니다.

content/ko/docs/contribute/new-content/open-a-pr.md

또는, 컴퓨터에 `hugo` 명령을 설치하여 사용한다.

1. [`website/netlify.toml`](https://raw.githubusercontent.com/kubernetes/website/main/netlify.toml)에 지정된 [Hugo (Extended edition)](https://gohugo.io/getting-started/installing/)과
Copy link
Member

@Eundms Eundms Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. [`website/netlify.toml`](https://raw.githubusercontent.com/kubernetes/website/main/netlify.toml)에 지정된 [Hugo (확장 에디션)](https://gohugo.io/getting-started/installing/)과
  • Extended edition 도 확장 에디션으로 번역이 가능합니다.

content/ko/docs/contribute/new-content/open-a-pr.md
이 명령의 결과에 여러 파일이 충돌된 것으로 표시된다.

1. 충돌한 각 파일을 열고 충돌 마커(`>>>`,`<<<` 그리고 `===`)를 찾는다.
1. 각 충돌 파일을 열고 충돌 마커(`>>>`,`<<<` 그리고 `===`)를 찾는다.
Copy link
Member

@Eundms Eundms Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. 각 충돌 파일을 열고 충돌 마커(`>>>`,`<<<` 그리고 `===`)를 찾는다.
1. 각 충돌 파일을 열고 `>>>`,`<<<` , `===`와 같은 충돌 마커를 찾는다.
  • 자연스럽게 변경해보았습니다.

content/ko/docs/contribute/new-content/open-a-pr.md

<!-- See https://github.com/kubernetes/website/issues/28808 for live-editor URL to this figure -->
<!-- You can also cut/paste the mermaid code into the live editor at https://mermaid-js.github.io/mermaid-live-editor to play around with it -->

Copy link
Member

@Eundms Eundms Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
매주 특정 문서 승인자가 자원하여 풀 리퀘스트를 분류하고 검토한다.
이 사람은 해당 주의 "PR 랭글러(Wrangler)"이다. 자세한
  • line 15 ~ 16 : 번역을 자연스럽게 변경하여보았습니다.

content/ko/docs/contribute/new-content/open-a-pr.md

<!-- See https://github.com/kubernetes/website/issues/28808 for live-editor URL to this figure -->
<!-- You can also cut/paste the mermaid code into the live editor at https://mermaid-js.github.io/mermaid-live-editor to play around with it -->

Copy link
Member

@Eundms Eundms Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
적용되지만, 리뷰어와 승인자는 다음을 수행해야 한다.
  • line 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianychoi ianychoi Awaiting requested review from ianychoi

@seokho-son seokho-son Awaiting requested review from seokho-son

1 more reviewer

@Eundms Eundms Eundms left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Eundms Eundms

Labels

area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ko] Update content/ko/docs/contribute/new-content/open-a-pr.md

3 participants

@esunn0412 @k8s-ci-robot @Eundms