Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the typo of serviceaccount #5533

Merged
merged 2 commits into from
Sep 26, 2017
Merged

fix the typo of serviceaccount #5533

merged 2 commits into from
Sep 26, 2017

Conversation

jianglingxia
Copy link
Contributor

@jianglingxia jianglingxia commented Sep 19, 2017 •
edited by k8s-reviewable
Loading

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.8 Features: set Milestone to 1.8 and Base Branch to release-1.8
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.

Please delete this note before submitting the pull request.

Allow edits from maintainers checkbox
image

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Sep 19, 2017 •
edited
Loading

Deploy preview ready!

Built with commit f3934be

https://deploy-preview-5533--kubernetes-io-master-staging.netlify.com

xiangpengzhao
xiangpengzhao previously requested changes Sep 19, 2017
View reviewed changes
docs/tasks/configure-pod-container/configure-service-account.md Outdated
namespace: 7 bytes
ca.crt: 1338 bytes
namespace: 7 bytes
token: eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJrdWJlcm5ldGVzL3NlcnZpY2VhY2NvdW50Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9uYW1lc3BhY2UiOiJkZWZhdWx0Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9zZWNyZXQubmFtZSI6ImJ1aWxkLXJvYm90LXNlY3JldCIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VydmljZS1hY2NvdW50Lm5hbWUiOiJidWlsZC1yb2JvdCIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VydmljZS1hY2NvdW50LnVpZCI6ImRhNjhmOWM2LTlkMjYtMTFlNy1iODRlLTAwMmRjNTI4MDBkYSIsInN1YiI6InN5c3RlbTpzZXJ2aWNlYWNjb3VudDpkZWZhdWx0OmJ1aWxkLXJvYm90In0.l5LmE4XfU_aMXr0tewL2TCfJa4-jjng9-l5yohyoBqUzt9IT45dal05q-9dJzT1oCfJTPBO8gg-6Gg-PsKv8hoTlHY5bxE1MFkVxulhns135TmUK1-PCPPT0-7okbPn6bRD0f-L0p6G4wNkUXLk3HlWM5MO2GthENopFwPvdWe5W2IbJSHVNbgbAkuC1zDapxI5uNwfdQ3oS16Tw0O1H7G4vYL2XUYgBt25kkIvvgYjLjTDwV_IC8b_zV19mXEc8Q62eg8PQAGbmm9e5mTCprNxvFF45rIET0njfiQvq8xPaYClWrpKiaSNhth_OCJqMrzJBoLDWW-orianwZ3coQg
```

**Note:** The content of `token` is elided here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to list the value of a token in the example? If so, this line should be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend removing token value and restoring original elided content

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "..." to replace token value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to know that namespace‘s Order is a problem? or leave it alone?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter. Leave the namespace order as you modified is ok. What you need to do now is to revert the token content :)

Bradamant3
Bradamant3 previously requested changes Sep 19, 2017
View reviewed changes
Copy link
Contributor

@Bradamant3 Bradamant3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert change to token field.

@jianglingxia
Copy link
Contributor Author

I have updated it that revert change to token field,thanks!

@jianglingxia
Copy link
Contributor Author

cc @Bradamant3

@jianglingxia
Copy link
Contributor Author

/assign @chenopis

@chenopis chenopis dismissed stale reviews from xiangpengzhao and Bradamant3 September 26, 2017 18:40

The change to the token field has been reverted.

@chenopis chenopis merged commit ad4dc7c into kubernetes:master Sep 26, 2017
chenopis added a commit that referenced this pull request Sep 27, 2017
@chenopis
Merge branch 'master' of https://github.com/kubernetes/kubernetes.git…
4ad495b 
…hub.io into release-1.8

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (87 commits)
  fix envFrom in configmap
  Add link to example for CRDs (#5641)
  Fixed links to architecture.md and principles.md
  Polish AppArmor tutorial
  Remove dangling files related to apparmor
  fix the typo of serviceaccount (#5533)
  Correct setup link (#5634)
  relink the  persistent volume of petset (#5582)
  Updates to case study landing page (#5629)
  translate doc resource-quotas into chinese
  minor encoding fix for CN page
  fix typo
  concepts-overview-components+abac-fix
  concepts-overview-components-fix
  Update links to avoid redirects. (#5627)
  Update links to avoid redirects. (#5625)
  Fix 404s. (#5624)
  Fix 404s. (#5623)
  Edits cpu-constraint-namespace.md
  Fix index redirects (#5502)
  ...

# Conflicts:
#	_redirects
#	docs/concepts/storage/volumes.md
#	docs/concepts/workloads/controllers/daemonset.md
#	docs/concepts/workloads/controllers/petset.md
#	docs/concepts/workloads/controllers/statefulset.md
#	docs/tasks/run-application/run-single-instance-stateful-application.md
#	docs/tutorials/stateful-application/zookeeper.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangpengzhao xiangpengzhao xiangpengzhao left review comments

@zhangxiaoyu-zidif zhangxiaoyu-zidif zhangxiaoyu-zidif left review comments

@Bradamant3 Bradamant3 Bradamant3 left review comments

Assignees

@Bradamant3 Bradamant3

@chenopis chenopis

@jianglingxia jianglingxia

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jianglingxia @k8sio-netlify-preview-bot @zhangxiaoyu-zidif @Bradamant3 @xiangpengzhao @k8s-ci-robot @chenopis