Documented service annotation for AWS ELB SSL policy #6261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
Deploy preview ready! Built with commit c59e38a https://deploy-preview-6261--kubernetes-io-vnext-staging.netlify.com |
|
@micahhausler FYI, the Travis CI error has been fixed. Please rebase or update your branch. Thx! |
micahhausler
force-pushed
the
aws-elb-ssl-policy
branch
from
9206178 to
15ee4d5
Compare
tengqm
reviewed
Nov 10, 2017
| aws elb describe-load-balancer-policies --query 'PolicyDescriptions[].PolicyName' | ||
| ``` | ||
|
|
||
| Any one of those policies can then be specified using the following annotation: |
There was a problem hiding this comment.
(trying to be picky ...)
using the following annotation:
using the "service.beta.kubernetes.io/aws-load-balancer-ssl-negotiation-policy" annotation, for example:
micahhausler
force-pushed
the
aws-elb-ssl-policy
branch
from
15ee4d5 to
a8c19e3
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
tengqm
approved these changes
Nov 10, 2017
|
@micahhausler Can you resolve the merge conflict? Thanks. |
micahhausler
force-pushed
the
aws-elb-ssl-policy
branch
from
a8c19e3 to
c59e38a
Compare
|
@steveperry-53 This is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is dependent on kubernetes/kubernetes#54507
ping @justinsb
This change is