-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change replicaset documentation to use apps/v1 API #6496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Nov 29, 2017
Deploy preview ready! Built with commit f292ac7 https://deploy-preview-6496--kubernetes-io-master-staging.netlify.com |
kow3ns
approved these changes
Nov 30, 2017
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Nov 30, 2017
@crimsonfaith91 Since this change is mostly about v1.9 changes, please consider rebase it on release-1.9 branch. Thanks. |
k8s-ci-robot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Nov 30, 2017
k8s-ci-robot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Nov 30, 2017
crimsonfaith91
force-pushed
the
rs-v1
branch
from
November 30, 2017 18:17
8d150b6
to
f292ac7
Compare
k8s-ci-robot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Nov 30, 2017
k8s-ci-robot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Nov 30, 2017
@tengqm Done! |
This was referenced Dec 3, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes replicaset documentation to use apps/v1 API.
/assign @kow3ns
This change is