Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare ipvs proxier beta #6524

Closed
wants to merge 2 commits into from
Closed

declare ipvs proxier beta #6524

wants to merge 2 commits into from

Conversation

stewart-yu
Copy link
Contributor

@stewart-yu stewart-yu commented Dec 1, 2017

ipvs alpha version -> beta version

cc @m1093782566

Allow edits from maintainers checkbox


This change is Reviewable

ipvs alpha version -> beta version
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2017
@stewart-yu
Copy link
Contributor Author

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Dec 1, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Dec 1, 2017

Deploy preview ready!

Built with commit 0c01661

https://deploy-preview-6524--kubernetes-io-master-staging.netlify.com

@m1093782566
Copy link

m1093782566 commented Dec 1, 2017

@a-mccarthy @steveperry-53 @jaredbhatti

It's very import to IPVS proxier beta work, please take a look when you have a chance. Thanks!

@m1093782566
Copy link

m1093782566 commented Dec 1, 2017

We want to declare IPVS proxier beta in v1.9, see kubernetes/enhancements#265

This PR is also the required document in https://docs.google.com/spreadsheets/d/1WmMJmqLvfIP8ERqgLtkKuE_Q2sVxX8ZrEcNxlVIJnNc/ for 'Implement IPVS-based in-cluster service load balancing' feature.

@m1093782566
Copy link

/cc @thockin

@k8s-ci-robot k8s-ci-robot requested a review from thockin December 1, 2017 01:14
@stewart-yu stewart-yu changed the title Update service.md declare ipvs proxier beta Dec 1, 2017
@tengqm tengqm added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Dec 1, 2017
@tengqm
Copy link
Contributor

tengqm commented Dec 1, 2017

adding do-not-merge because kubernetes/kubernetes#56623 is still not in. Docs should be updated only when the implementation is in place.

removing critical-urgent because ... cannot feel the urgency

@m1093782566
Copy link

m1093782566 commented Dec 1, 2017

@tengqm

Docs should be updated only when the implementation is in place.

implementation is already in place!

adding do-not-merge because kubernetes/kubernetes#56623 is still not in.

kubernetes/kubernetes#56623 just declares beta.

@tengqm
Copy link
Contributor

tengqm commented Dec 1, 2017

@m1093782566 it is not yet officially announced as beta, so please hold doc changes.

@tengqm tengqm removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2017
@tengqm
Copy link
Contributor

tengqm commented Dec 5, 2017

kubernetes/kubernetes#56623 is in now... this one is good to go.
@m1093782566 Please rebase this to the release-1.9 branch. Thanks.

@stewart-yu
Copy link
Contributor Author

Does need commit another PR to release-1.9 branch? This PR just compare with master branch. @tengqm

@tengqm
Copy link
Contributor

tengqm commented Dec 5, 2017

@stewart-yu Yes. A commit to release-1.9 is needed. Look, the process of merging documentation is a little bit different from that for a code repo. If a doc PR is targeting Master and it is merged, the content is published on k8s.io/docs immediately. Commiting to release-1.9 will help ensure that v1.9 specific contents are only online when it is officially released.

@tengqm
Copy link
Contributor

tengqm commented Dec 5, 2017

Closing this for merging #6558 into release-1.9.

@tengqm tengqm closed this Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants