[community/kep pages] Add automated handling for links from imported files #6926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
Broken links fixed with kubernetes/community#1587 |
jesscodez
commented
Jan 11, 2018
| @@ -159,25 +176,33 @@ func main() { | |||
| fmt.Fprintf(os.Stdout, "\n\t\t\t*\t*\t*\n\nDocs imported! Run 'git add .' 'git commit -m <comment>' and 'git push' to upload them.\n") | |||
| } | |||
|
|
|||
| func copyFile(src, dst string) error { | |||
There was a problem hiding this comment.
removing this function, i checked and it's not being used anywhere
|
/cc @castrojo |
|
I'm going to merge this and do more extensive testing w/ the kubectl docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chenopis PTAL
I've tried to generalize this solution and not make it too brittle---basically if you mark the import config file (e.g.
community.yml) withgen-absolute-links, it processes URLs from the imported pages as follows, depending on their type:#id-on-page- leaves these URLs as they are/path/url- adds the remote repo URL prefixpath/url,./path.url- adds the remote repo URL and the relevant file's subpath as a prefixhttp://,https://- leaves these URLs as they aremailto:- leaves these URLs as they areRegex works for now, but people well-versed in parsing can likely come up with a cleaner solution.
Some of the URLs are broken because things in community have been moved around, I'll follow up on the CI report and fix them accordingly.
This change is