-
Notifications
You must be signed in to change notification settings - Fork 14.7k
doc: fix some typo #7229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix some typo #7229
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 794cd47 https://deploy-preview-7229--kubernetes-io-master-staging.netlify.com |
@halfcrazy these are great updates, thank you for taking the time to do this PR! That said, there are some that will be only ephemeral changes as the pages that you're making changes are from generated documentation. Pages where the URI includes There's some docs on how we generate content for these pages:
But the long and short is that changes to typo's in there usually need to be hunted down and resolved in the source code from where the documentation is generated. |
/assign @zacharysarah |
@heckj Good catch, I have sent some pr to kubernetes repo to correct some of those typos in the code comment. https://github.com/kubernetes/kubernetes/pulls/halfcrazy |
@halfcrazy 👋 I see you've opened upstream PRs for typos in generated docs--thanks. I'll go ahead and approve this PR to make changes to regular content. 👍 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: halfcrazy, zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
@halfcrazy Please resolve the merge conflicts. /hold |
@zacharysarah update. |
/unhold |
This change is