Skip to content

doc: fix some typo #7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2018
Merged

doc: fix some typo #7229

merged 1 commit into from
Feb 14, 2018

Conversation

halfcrazy
Copy link
Contributor

@halfcrazy halfcrazy commented Feb 4, 2018

NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>

Please delete this note before submitting the pull request.

Allow edits from maintainers checkbox


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 4, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 794cd47

https://deploy-preview-7229--kubernetes-io-master-staging.netlify.com

@heckj
Copy link
Contributor

heckj commented Feb 4, 2018

@halfcrazy these are great updates, thank you for taking the time to do this PR! That said, there are some that will be only ephemeral changes as the pages that you're making changes are from generated documentation. Pages where the URI includes generated or imported are generally ones that have come from an automatic process - usually driven by code elsewhere. All this to let you know that the next time those pages are generated and updated (usually on the quarterly release, but sometimes more frequently) the spelling changes you're proposing there will revert.

There's some docs on how we generate content for these pages:

But the long and short is that changes to typo's in there usually need to be hunted down and resolved in the source code from where the documentation is generated.

@heckj
Copy link
Contributor

heckj commented Feb 4, 2018

/assign @zacharysarah

@halfcrazy
Copy link
Contributor Author

@heckj Good catch, I have sent some pr to kubernetes repo to correct some of those typos in the code comment. https://github.com/kubernetes/kubernetes/pulls/halfcrazy

@zacharysarah
Copy link
Contributor

@halfcrazy 👋 I see you've opened upstream PRs for typos in generated docs--thanks. I'll go ahead and approve this PR to make changes to regular content. 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: halfcrazy, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2018
@zacharysarah
Copy link
Contributor

@halfcrazy Please resolve the merge conflicts.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2018
@halfcrazy
Copy link
Contributor Author

@zacharysarah update.

@zacharysarah
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit f51d11f into kubernetes:master Feb 14, 2018
tehut pushed a commit to tehut/website that referenced this pull request Feb 20, 2018
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants