Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--show-all is now defaulted to true and deprecated #7749

Closed
wants to merge 1 commit into from
Closed

--show-all is now defaulted to true and deprecated #7749

wants to merge 1 commit into from

Conversation

ChiuWang
Copy link
Contributor

@ChiuWang ChiuWang commented Mar 14, 2018 •
edited
Loading

Default value of --show-all is true now, and will be inert soon.

ref: k8s #60210

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: steveperry-53

Assign the PR to them by writing /assign @steveperry-53 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1419699

https://deploy-preview-7749--kubernetes-io-master-staging.netlify.com

@Bradamant3
Copy link
Contributor

pretty sure this should go against the release-1.10 docs branch, yes? @charrywanganthony please confirm and change if needed.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2018
@ChiuWang ChiuWang changed the title Default value of --show-all is true now, --show-all will be inert in v1.11. --show-all is now defaulted to true and deprecated Mar 14, 2018
@ChiuWang
Copy link
Contributor Author

@Bradamant3 it has no conflicts with master branch.

@Bradamant3
Copy link
Contributor

Bradamant3 commented Mar 14, 2018 •
edited
Loading

sorry if I wasn't clear, @charrywanganthony -- is this new in K8s 1.10? If so, the PR needs a base branch of release-1.10, not master.

Also doesn't PR #7574 cover at least part of this change?

@Bradamant3 Bradamant3 added this to the 1.10 milestone Mar 14, 2018
@Bradamant3
Copy link
Contributor

/assign

@ChiuWang
Copy link
Contributor Author

sorry。 I didn't notice that.

@ChiuWang ChiuWang closed this Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@Bradamant3 Bradamant3

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@ChiuWang @k8s-ci-robot @k8sio-netlify-preview-bot @Bradamant3