SupportIPVSProxyMode is GA #8850

Lion-Wei · 2018-06-01T06:16:54Z

Update feature gate reference for 1.11
kubernetes/kubernetes#58442

k8sio-netlify-preview-bot · 2018-06-01T06:16:56Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit ec09f38

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b158383dd6a5466ed916806

Lion-Wei · 2018-06-01T06:18:24Z

/cc @m1093782566
/assign @chenopis
Please take a look, thanks.

m1093782566 · 2018-06-01T06:25:46Z

/lgtm

tengqm · 2018-06-01T07:20:11Z

Please do not touch the autogenerated files.
@Bradamant3 I have seen quite a few PRs attempting to manually change the generated files. Maybe our last move to the relocate these files out of a 'generated' directory is leading to such a situation. What do you think?

Lion-Wei · 2018-06-01T07:52:29Z

@tengqm Sure, sorry didn't notice. Fixed. : )

m1093782566 · 2018-06-01T07:53:10Z

/lgtm

mdlinville

/hold

Please revert the change to the generated doc. Thanks!

mdlinville · 2018-06-01T22:22:32Z

content/en/docs/reference/command-line-tools-reference/kubelet.md

@@ -382,7 +382,7 @@ kubelet
      <td colspan="2">--feature-gates mapStringBool</td>


Revert changes to this file, as it is generated. These docs will be updated as part of the 1.11 docs release process.

@Lion-Wei Can you fix it?

Lion-Wei · 2018-06-02T07:53:33Z

@mistyhacks Fixed, thanks.

m1093782566 · 2018-06-02T09:44:55Z

/lgtm

tengqm · 2018-06-04T02:25:40Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -85,8 +85,9 @@ different Kubernetes components.
 | `StorageObjectInUseProtection` | `true` | GA | 1.11 | |
 | `StreamingProxyRedirects` | `true` | Beta | 1.5 | |
 | `SupportIPVSProxyMode` | `false` | Alpha | 1.8 | 1.8 |
-| `SupportIPVSProxyMode` | `false` | Beta | 1.9 | 1.9 |
-| `SupportIPVSProxyMode` | `true` | Beta | 1.10 | |
+| `SupportIPVSProxyMode` | `false` | Beta | 1.9 | |


Youd didn't want to change this line, right?

I think this column means the last version that we can use SupportIPVSProxyMode feature gate, and that should be 1.10, so I deleted 1.9.

The correct way to interpret this line is "the feature foo was in Beta and set to false starting 1.9, and that state ends at 1.9".
Then we have the next line, "the feature was still Beta, but default to true starting 1.10, and that state ends at 1.10".
Then the next line "the feature is GA starting 1.11 and default to True, and that state persists ..."

You are not supposed to remove the last column on line 88.

Right, I see, will change soon. Thanks.

m1093782566 · 2018-06-04T07:14:48Z

LGTM in technical view.

tengqm

/lgtm
/approve

tengqm · 2018-06-04T15:08:48Z

@mistyhacks Approved and then realized that this should be handed over to you because it is 1.11.

mdlinville · 2018-06-04T18:22:59Z

I rebased to resolve conflicts

k8s-ci-robot · 2018-06-04T18:23:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

m1093782566 · 2018-06-05T01:38:36Z

Thanks all!

Let's merge this PR.

/lgtm

m1093782566 · 2018-06-05T01:39:18Z

/hold cancel since @mistyhacks approved.

zacharysarah · 2018-06-05T23:24:10Z

@tengqm Please be mindful of PRs in release branches. It's important to avoid a repeat of the premature approvals during 1.9.

Re:#8745, this is also a specific instance of why approver status requires input and discussion from other maintainers prior to approval. Increased power requires increased responsibility and, in open source software especially, increased collaboration.

tengqm · 2018-06-06T00:34:42Z

@zacharysarah Thanks.

zacharysarah · 2018-06-06T19:58:39Z

@tengqm For what to do differently next time: if you realize that you've mistakenly approved a PR, /approve cancel as soon as possible. In the case of this PR, the /approve remained after you caught the mistake, allowing another user to /lgtm and /hold cancel to merge.

tengqm · 2018-06-07T02:29:56Z

@zacharysarah got it.

* Seperate priority and preemption (#8144) * Doc about PID pressure condition. (#8211) * Doc about PID pressure condition. Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * "so" -> "too" * Update version selector for 1.11 * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * CRIContainerLogRotation is Beta in 1.11 (#8665) * Seperate priority and preemption (#8144) * CRIContainerLogRotation is Beta in 1.11 xref: kubernetes/kubernetes#64046 * Bring StorageObjectInUseProtection feature to GA (#8159) * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * Bring StorageObjectInUseProtection feature to GA StorageObjectInUseProtection is Beta in K8s 1.10. It's brought to GA in K8s 1.11. * Fixed typo and added feature state tags. * Remove KUBE_API_VERSIONS doc (#8292) The support to the KUBER_API_VERSIONS environment variable is completely dropped (no deprecation). This PR removes the related doc in release-1.11. xref: kubernetes/kubernetes#63165 * Remove InitialResources from admission controllers (#8293) The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784 * Remove docs related to in-tree support to GPU (#8294) * Remove docs related to in-tree support to GPU The in-tree support to GPU is completely removed in release 1.11. This PR removes the related docs in release-1.11 branch. xref: kubernetes/kubernetes#61498 * Update content updated by PR to Hugo syntax Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Update the doc about extra volume in kubeadm config (#8453) Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com> * Update CRD Subresources for 1.11 (#8519) * coredns: update notes in administer-cluster/coredns.md (#8697) CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS. * kubeadm-alpha: CoreDNS related changes (#8727) Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md * Update cloud controller manager docs to beta 1.11 (#8756) * Update cloud controller manager docs to beta 1.11 * Use Hugo shortcode for feature state * kubeadm-upgrade: include new command `kubeadm upgrade diff` (#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance. * independent: update CoreDNS mentions for kubeadm (#8753) Give CoreDNS instead of kube-dns examples in: - docs/setup/independent/create-cluster-kubeadm.md - docs/setup/independent/troubleshooting-kubeadm.md * update 1.11 --server-print info (#8870) * update 1.11 --server-print info * Copyedit * Mark ExpandPersistentVolumes feature to beta (#8778) * Update version selector for 1.11 * Mark ExpandPersistentVolumes Beta xref: kubernetes/kubernetes#64288 * fix shortcode, add placeholder files to fix deploy failures (#8874) * declare ipvs ga (#8850) * kubeadm: update info about CoreDNS in kubeadm-init.md (#8728) Add info to install kube-dns instead of CoreDNS, as CoreDNS is the default DNS server in 1.11. Add notes that kubeadm config images can be used to list and pull the required images in 1.11. * kubeadm: update implementation-details.md about CoreDNS (#8829) - Replace examples from kube-dns to CoreDNS - Add notes about the CoreDNS feature gate status in 1.11 - Add note that the service name for CoreDNS is also called `kube-dns` * Update block device support for 1.11 (#8895) * Update block device support for 1.11 * Copyedits * Fix typo 'fiber channel' (#8957) Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * kubeadm-upgrade: add the 'node [config]' sub-command (#8960) - Add includes for the generated pages - Include placeholder generated pages * kubeadm-init: update the example for the MasterConfiguration (#8958) - include godocs link for MasterConfiguration - include example MasterConfiguration - add note that `kubeadm config print-default` can be used * kubeadm-config: include new commands (#8862) Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above. * administer-cluster/coredns: include more changes (#8985) It was requested that for this page a couple of methods should be outlined: - manual installation for CoreDNS explained at the Kubernetes section of the GitHub project for CoreDNS - installation and upgrade via kubeadm Make the above changes and also add a section "About CoreDNS". This commit also lowercases a section title. * Update CRD subresources doc for 1.11 (#8918) * Add docs for volume expansion and online resizing (#8896) * Add docs for volume expansion going beta * Copyedit * Address feedback * Update exec plugin docs with TLS credentials (#8826) * Update exec plugin docs with TLS credentials kubernetes/kubernetes#61803 implements TLS client credential support for 1.11. * Copyedit * More copyedits for clarification * Additional copyedit * Change token->credential * NodeRestriction admission prevents kubelet taint removal (#8911) * dns-custom-namerserver: break down the page into mutliple sections (#8900) * dns-custom-namerserver: break down the page into mutliple sections This page is currently about kube-dns and is a bit outdated. Introduce the heading `# Customizing kube-dns`. Introduce a separate section about CoreDNS. * Copyedits, fix headings for customizing DNS Hey Lubomir, I coypedited pretty heavily because this workflow is so much easier for docs and because I'm trying to help improve everything touching kubeadm as much as possible. But there's one outstanding issue wrt headings and intro content: you can't add a heading 1 to a topic to do what you wanted to do. The page title in the front matter is rendered as a heading 1 and everything else has to start at heading 2. (We still need to doc this better in the docs contributing content, I know.) Instead, I think we need to rewrite the top-of-page intro content to explain better the relationship between kube-dns and CoreDNS. I'm happy to write something, but I thought I'd push this commit first so you can see what I'm doing. Hope it's all clear -- ping here or on Slack with any questions ~ Jennifer * Interim fix for talking about CoreDNS * Fix CoreDNS details * PSP readOnly hostPath (#8898) * Add documentation for crictl (#8880) * Add documentation for crictl * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Final copyedit * VolumeSubpathEnvExpansion alpha feature (#8835) * Note that Heapster is deprecated (#8827) * Note that Heapster is deprecated This notes that Heapster is deprecated, and migrates the relevant docs to talk about metrics-server or other solutions by default. * Copyedits and improvements Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * fix shortcode to troubleshoot deploy (#9057) * update dynamic kubelet config docs for v1.11 (#8766) * update dynamic kubelet config docs for v1.11 * Substantial copyedit * Address feedback * Reference doc for kubeadm (release-1.11) (#9044) * Reference doc for kubeadm (release-1.11) * fix shortcode to troubleshoot deploy (#9057) * Reference doc for kube-components (release-1.11) (#9045) * Reference doc for kube-components (release-1.11) * Update cloud-controller-manager.md * fix shortcode to troubleshoot deploy (#9057) * Documentation on lowercasing kubeadm init apiserver SANs (#9059) * Documentation on lowercasing kubeadm init apiserver SANs * fix shortcode to troubleshoot deploy (#9057) * Clarification in dynamic Kubelet config doc (#9061) * Promote sysctls to Beta (#8804) * Promote sysctls to Beta * Copyedits Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Review comments * Address feedback * More feedback * kubectl reference docs for 1.11 (#9080) * Update Kubernetes API 1.11 ref docs (#8977) * Update v1alpha1 to v1beta1. * Adjust left nav for 1.11 ref docs. * Trim list of old ref docs. * Update Federation API ref docs for 1.11. (#9064) * Update Federation API ref docs for 1.11. * Add titles. * Update definitions.html * CRD versioning Public Documentation (#8834) * CRD versioning Public Documentation * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * More rewrites * Address feedback * Update main CRD page in light of versioning * Reorg CRD docs * Further reorg * Tweak title * CSI documentation update for raw block volume support (#8927) * CSI documetation update for raw block volume support * minor edits for "CSI raw block volume support" Some small grammar and style nits. * minor CSIBlockVolume edits * Update kubectl component ref page for 1.11. (#9094) * Update kubectl component ref page for 1.11. * Add title. Replace stevepe with username. * crd versioning doc: fix nits (#9142) * Update `DynamicKubeletConfig` feature to beta (#9110) xref: kubernetes/kubernetes#64275 * Documentation for dynamic volume limits based on node type (#8871) * add cos for storage limits * Update docs specific for aws and gce * fix some minor things * Update storage-limits.md * Add k8s version to feature-state shortcode * The Doc update for ScheduleDaemonSetPods (#8842) Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * Update docs related to PersistentVolumeLabel admission control (#9109) The said admission controller is disabled by default in 1.11 (kubernetes/kubernetes#64326) and scheduled to be removed in future release. * client exec auth: updates for 1.11 (#9154) * Updates HA kubeadm docs (#9066) * Updates HA kubeadm docs Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * kubeadm HA - Add stacked control plane steps * ssh instructions and some typos in the bash scripts Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * Fix typos and copypasta errors * Fix rebase issues * Integrate more changes Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * copyedits, layout and formatting fixes * final copyedits * Adds a sanity check for load balancer connection Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * formatting fixes, copyedits * fix typos, formatting * Document the Pod Ready++ feature (#9180) Closes: #9107 Xref: kubernetes/kubernetes#64057 * Mention 'KubeletPluginsWatcher' feature (#9177) * Mention 'KubeletPluginsWatcher' feature This feature is more developers oriented than users oriented, so simply mention it in the feature gate should be fine. In future, when the design doc is migrated from Google doc to the kubernetes/community repo, we can add links to it for users who want to dig deeper. Closes: #9108 Xref: kubernetes/kubernetes#63328, kubernetes/kubernetes#64605 * Copyedit * Amend dynamic volume list docs (#9181) The dynamic volume list feature has been documented but the feature gate related was not there yet. Closes: #9105 * Document for service account projection (#9182) This adds docs for the service account projection feature. Xref: kubernetes/kubernetes#63819, kubernetes/community#1973 Closes: #9102 * Update pod priority and preemption user docs (#9172) * Update pod priority and preemption user docs * Copyedit * Documentation on setting node name with Kubeadm (#8925) * Documentation on setting node name with Kubeadm * copyedit * Add kubeadm upgrade docs for 1.11 (#9089) * Add kubeadm upgrade docs for 1.11 * Initial docs review feedback * Add 1-11 to outline * Fix formatting on tab blocks * Move file to correct location * Add `kubeadm upgrade node config` step * Overzealous ediffing * copyedit, fix lists and headings * clarify --force flag for fixing bad state * Get TOML ready for 1.11 release * Blog post for 1.11 release (#9254) * Blog post for 1.11 release * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2018

k8s-ci-robot requested review from xiangpengzhao and zhangxiaoyu-zidif June 1, 2018 06:16

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 1, 2018

k8s-ci-robot assigned chenopis Jun 1, 2018

k8s-ci-robot requested a review from m1093782566 June 1, 2018 06:18

k8s-ci-robot assigned m1093782566 Jun 1, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018

mdlinville added this to the 1.11 milestone Jun 1, 2018

mdlinville reviewed Jun 1, 2018

View reviewed changes

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 1, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2018

tengqm reviewed Jun 4, 2018

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2018

tengqm approved these changes Jun 4, 2018

View reviewed changes

k8s-ci-robot assigned tengqm Jun 4, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2018

mdlinville force-pushed the release-1.11 branch from 4b3430b to 7549d77 Compare June 4, 2018 17:24

declare ipvs ga

ec09f38

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2018

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2018

k8s-ci-robot merged commit ef11602 into kubernetes:release-1.11 Jun 5, 2018

k82cn pushed a commit to k82cn/website that referenced this pull request Jun 11, 2018

declare ipvs ga (kubernetes#8850)

2d30248

mdlinville pushed a commit that referenced this pull request Jun 20, 2018

declare ipvs ga (#8850)

c9a1cd1

mdlinville pushed a commit that referenced this pull request Jun 27, 2018

declare ipvs ga (#8850)

97d0c87

mdlinville pushed a commit that referenced this pull request Jun 27, 2018

declare ipvs ga (#8850)

1821a94

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SupportIPVSProxyMode is GA #8850

SupportIPVSProxyMode is GA #8850

Lion-Wei commented Jun 1, 2018

k8sio-netlify-preview-bot commented Jun 1, 2018 •

edited

Loading

Lion-Wei commented Jun 1, 2018

m1093782566 commented Jun 1, 2018

tengqm commented Jun 1, 2018

Lion-Wei commented Jun 1, 2018

m1093782566 commented Jun 1, 2018

mdlinville left a comment

mdlinville Jun 1, 2018

m1093782566 Jun 2, 2018

Lion-Wei Jun 2, 2018

Lion-Wei commented Jun 2, 2018

m1093782566 commented Jun 2, 2018

tengqm Jun 4, 2018

Lion-Wei Jun 4, 2018

tengqm Jun 4, 2018

Lion-Wei Jun 4, 2018

m1093782566 commented Jun 4, 2018

tengqm left a comment

tengqm commented Jun 4, 2018

mdlinville commented Jun 4, 2018

k8s-ci-robot commented Jun 4, 2018

m1093782566 commented Jun 5, 2018

m1093782566 commented Jun 5, 2018 •

edited

Loading

zacharysarah commented Jun 5, 2018 •

edited

Loading

tengqm commented Jun 6, 2018

zacharysarah commented Jun 6, 2018 •

edited

Loading

tengqm commented Jun 7, 2018

		@@ -382,7 +382,7 @@ kubelet
		<td colspan="2">--feature-gates mapStringBool</td>

SupportIPVSProxyMode is GA #8850

SupportIPVSProxyMode is GA #8850

Conversation

Lion-Wei commented Jun 1, 2018

k8sio-netlify-preview-bot commented Jun 1, 2018 • edited Loading

Lion-Wei commented Jun 1, 2018

m1093782566 commented Jun 1, 2018

tengqm commented Jun 1, 2018

Lion-Wei commented Jun 1, 2018

m1093782566 commented Jun 1, 2018

mdlinville left a comment

Choose a reason for hiding this comment

mdlinville Jun 1, 2018

Choose a reason for hiding this comment

m1093782566 Jun 2, 2018

Choose a reason for hiding this comment

Lion-Wei Jun 2, 2018

Choose a reason for hiding this comment

Lion-Wei commented Jun 2, 2018

m1093782566 commented Jun 2, 2018

tengqm Jun 4, 2018

Choose a reason for hiding this comment

Lion-Wei Jun 4, 2018

Choose a reason for hiding this comment

tengqm Jun 4, 2018

Choose a reason for hiding this comment

Lion-Wei Jun 4, 2018

Choose a reason for hiding this comment

m1093782566 commented Jun 4, 2018

tengqm left a comment

Choose a reason for hiding this comment

tengqm commented Jun 4, 2018

mdlinville commented Jun 4, 2018

k8s-ci-robot commented Jun 4, 2018

m1093782566 commented Jun 5, 2018

m1093782566 commented Jun 5, 2018 • edited Loading

zacharysarah commented Jun 5, 2018 • edited Loading

tengqm commented Jun 6, 2018

zacharysarah commented Jun 6, 2018 • edited Loading

tengqm commented Jun 7, 2018

k8sio-netlify-preview-bot commented Jun 1, 2018 •

edited

Loading

m1093782566 commented Jun 5, 2018 •

edited

Loading

zacharysarah commented Jun 5, 2018 •

edited

Loading

zacharysarah commented Jun 6, 2018 •

edited

Loading