-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admonition type to shortcode #9482
Add admonition type to shortcode #9482
Conversation
/hold |
Deploy preview for kubernetes-io-master-staging ready! Built with commit eea16e6 https://deploy-preview-9482--kubernetes-io-master-staging.netlify.com |
@lucperkins Thanks for this, it's a nice quality of life improvement. I'm happy to approve it when you're ready. 👍 |
/assign |
@lucperkins Ping--looks like #10355 (and any dependent PRs it spawns) is the last of the language-related PRs. Pending merge conflict resolution, is this PR still good to go? |
@zacharysarah This is good to go. In the future I'd like to use localized terms for "note," "caution," etc. but I think we can punt on that, as the Chinese repo, for one, was already using the English terms and the others may be as well. |
/approve |
/hold cancel |
/assign @kbarnard10 |
@zparnold Okay, this is once again ready to go. |
/lgtm |
@lucperkins 👋 Good grief, looks like previous /approve |
@lucperkins 👋 Ping |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah, zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zacharysarah Done! |
/lgtm |
In response to issue #9397.
This is mostly done but I'll need to wait on the current multilingual work (so that we can rely on language-specific terms for "note," "caution", etc.).