Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permalinks to in-page headings #9751

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Add permalinks to in-page headings #9751

merged 1 commit into from
Aug 18, 2018

Conversation

mdlinville
Copy link
Contributor

Add a clickable / copyable way to link to a specific page heading without the need to scroll up to the TOC to get the heading link.

@cody-clark FYI

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 3, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f103344

https://deploy-preview-9751--kubernetes-io-master-staging.netlify.com

@mdlinville mdlinville changed the title Add permalinks to in-page headings WIP Add permalinks to in-page headings Aug 6, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2018
@zparnold
Copy link
Member

zparnold commented Aug 8, 2018

@MistyHacks 💯 THIS IS AWESOME AND GOING TO BE SO USEFUL!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2018
@mdlinville mdlinville changed the title WIP Add permalinks to in-page headings Add permalinks to in-page headings Aug 10, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2018
@mdlinville
Copy link
Contributor Author

This is ready to go. Sorry about the !important in the CSS rules -- I don't have the patience to try to figure out what was hijacking the CSS. This makes everything from H1 to H6 clickable, adds an underline on hover, and reduces the opacity very slightly on hover to give an extra visual cue.

See https://deploy-preview-9751--kubernetes-io-master-staging.netlify.com/docs/setup/independent/install-kubeadm/ or the trusty smoke test page at https://deploy-preview-9751--kubernetes-io-master-staging.netlify.com/docs/test/#heading-levels.

@bradtopol
Copy link
Contributor

Great job @MistyHacks This is awesome!!!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit f8e4d35 into kubernetes:master Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mdlinville @k8sio-netlify-preview-bot @zparnold @bradtopol @k8s-ci-robot @chenopis