Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the spelling of "beginning" throughout the control library #323

Closed
wants to merge 2 commits into from

Conversation

craigbox
Copy link
Contributor

%s/beggining/beginning/g

(To be honest, I think root_of_path, start_of_path or first_node_in_path would be a better description for this term; let me know if I should change it further)

Signed-off-by: Craig Box <craigb@armosec.io>
@matthyx
Copy link
Contributor

matthyx commented Apr 3, 2023

I would go with start_of_path while we are at it... but I fear this could break either (or both) ChatGPT integration and user supplied rules?
But I am not familiar with this repo at all...

@craigbox
Copy link
Contributor Author

craigbox commented Apr 3, 2023

@yuleib @YiscahLevySilas1 FYI

Signed-off-by: Craig Box <craigb@armosec.io>
@yuleib yuleib requested review from yuleib and removed request for Daniel-GrunbergerCA April 3, 2023 12:49
@rotemamsa
Copy link
Contributor

@yuleib is there any updates with this issue?

@yuleib
Copy link
Contributor

yuleib commented Sep 27, 2023

@rotemamsa it's a veryt old PR, there are many conflicts here. i will try to clone it and solve the issues

@craigbox
Copy link
Contributor Author

craigbox commented Oct 2, 2023

Replaced by #512 which is a mergeable version of this PR.

@craigbox craigbox closed this Oct 2, 2023
@craigbox craigbox deleted the begin-the-begin branch October 2, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants