Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(exceptions): Edit system exceptions #481

Merged
merged 6 commits into from
Sep 4, 2023
Merged

Conversation

dwertent
Copy link

@dwertent dwertent commented Aug 1, 2023

PR Type:

Enhancement


PR Description:

This PR introduces enhancements to the system exceptions handling in the project. It adds support for system exceptions when setting a label or annotation with kubescape.io/ignore:true. The PR also updates the default exceptions with the latest controls. The changes are primarily reflected in the kubescape.json file.


PR Main Files Walkthrough:

exceptions/kubescape.json: The file has been significantly updated to include a new system exception named 'kubescape-ignore'. This exception is triggered when the label or annotation kubescape.io/ignore is set to true, yes, 1, enable, or enabled. Additionally, several new controls and resources have been added to the existing exceptions. The changes also include the addition of new attributes to the resources and posture policies.


User Description:

Overview

  • Support system exceptions when setting a label or annotation with kubescape.io/ignore:true
  • Update KS exceptions with the latest controls

David Wertenteil and others added 3 commits August 1, 2023 08:43
Signed-off-by: David Wertenteil <dwertent@armosec.io>
Signed-off-by: David Wertenteil <dwertent@armosec.io>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@dwertent dwertent marked this pull request as draft August 15, 2023 09:55
@dwertent
Copy link
Author

It looks like there is an issue in Kubescape.
I'm working on it.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@dwertent dwertent marked this pull request as ready for review September 4, 2023 06:34
@codiumai-pr-agent-free codiumai-pr-agent-free bot added the enhancement New feature or request label Sep 4, 2023
@codiumai-pr-agent-free
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Enhancing system exceptions handling
  • 📝 PR summary: This PR introduces enhancements to the system exceptions handling in the project. It adds support for system exceptions when setting a label or annotation with kubescape.io/ignore:true. The PR also updates the default exceptions with the latest controls.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The PR is well-structured and the changes are clear. However, it would be beneficial to include unit tests to ensure the new exceptions are working as expected. Additionally, it would be helpful to provide more context around the new controls added to the exceptions.

  • 🤖 Code feedback:

    • relevant file: exceptions/kubescape.json
      suggestion: Consider using a list or array for the "kubescape.io/ignore" attribute values to avoid redundancy. This will make the code more maintainable and easier to read. [important]
      relevant line: "attributes": {

    • relevant file: exceptions/kubescape.json
      suggestion: It would be beneficial to add comments explaining the purpose of the new controls added to the exceptions. This will make the code easier to understand for other developers. [medium]
      relevant line: {

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@dwertent dwertent merged commit 623bec0 into master Sep 4, 2023
46 checks passed
YiscahLevySilas1 added a commit that referenced this pull request Sep 5, 2023
@YiscahLevySilas1 YiscahLevySilas1 deleted the edit-exceptions branch April 14, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants