add coverage for phase2 synchronizer #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Summary:
|
|
Summary:
|
|
Summary:
|
|
Summary:
|
|
Summary:
|
|
Summary:
|
|
Summary:
|
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
|
Summary:
|
matthyx
commented
Oct 3, 2024
| _, err = c.dynamicClient.Resource(c.res).Namespace(id.Namespace).Apply(context.Background(), id.Name, &obj, metav1.ApplyOptions{FieldManager: "application/apply-patch"}) | ||
| options := metav1.ApplyOptions{ | ||
| FieldManager: "application/apply-patch", | ||
| Force: true, |
There was a problem hiding this comment.
@amirmalka I think I ran into the issue that we saw last month - do you think it's OK to force here?
There was a problem hiding this comment.
Eventually we discovered that the problem was trying to apply a namespaced object for a non-namespaced resource definition.
Why do we need to force? What is the issue you are seeing?
There was a problem hiding this comment.
right... well in this case we really need it since it's an existing object, that was updated in both sides, but we want the backend to have the last word on it
I think mechanism 1 applies here: https://pkg.go.dev/k8s.io/client-go/applyconfigurations#hdr-Controller_Support
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.