Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] configuration of resources requests and limits is not used #313

Closed
bcouetil opened this issue Jul 22, 2020 · 0 comments · Fixed by #330
Closed

[BUG] configuration of resources requests and limits is not used #313

bcouetil opened this issue Jul 22, 2020 · 0 comments · Fixed by #330
Labels
bug Something isn't working

Comments

@bcouetil
Copy link

Describe the bug

Thank you for this wonderful tool 😃

The configuration of resources requests and limits is not used in Helm Chart.

Nowhere in the deployment template I can find something like :

        resources:
{{ toYaml .Values.resources | indent 10 }}
@bcouetil bcouetil added the bug Something isn't working label Jul 22, 2020
@qlikcoe qlikcoe mentioned this issue Sep 3, 2020
Merged
@mergify mergify bot closed this as completed in #330 Sep 4, 2020
mergify bot pushed a commit that referenced this issue Sep 4, 2020
@qlikcoe
Add missing resources to the deployment.yaml (#330)
d33bd0c 
##### ISSUE TYPE
 - Bug fix Pull Request

##### SUMMARY
Adds missing `resources` section to the deployment manifest. 
Fixes #313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing resources to the deployment.yaml qlikcoe/botkube
1 participant
@bcouetil