Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] e2e tests are flaky #384

Closed
PrasadG193 opened this issue Oct 1, 2020 · 1 comment · Fixed by #389
Closed

[BUG] e2e tests are flaky #384

PrasadG193 opened this issue Oct 1, 2020 · 1 comment · Fixed by #389
Labels
bug Something isn't working

Comments

@PrasadG193
Copy link
Collaborator

Describe the bug

e2e tests on CI are failing for update events validate

See run history on master - e.g https://github.com/infracloudio/botkube/runs/1193896198
@PrasadG193 PrasadG193 added the bug Something isn't working label Oct 1, 2020
@akankshakumari393
Copy link
Contributor

@PrasadG193 e2e Tests are failing because update event validation goes through a series of create and update a resource, while validating the same from lastseenmessage, it gets the create operation result, instead of update sometimes and the tests fail.
Need to check on that.

@codenio codenio mentioned this issue Oct 1, 2020
Merged
@PrasadG193 PrasadG193 mentioned this issue Oct 5, 2020
Merged
@mergify mergify bot closed this as completed in #389 Oct 5, 2020
mergify bot pushed a commit that referenced this issue Oct 5, 2020
@codenio
Bug Fix e2e tests (#389)
b087f94 
This Commit, 
- Fixes build failure due to e2e tests

##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
 - Bug fix Pull Request

##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->

<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->

<!--- Please list dependencies added with your change also -->

Fixes #384
mszostok pushed a commit to mszostok/botkube that referenced this issue Jun 26, 2023
@mszostok
Hackathon migration cli (kubeshop#384)
a760ba8
mszostok pushed a commit to mszostok/botkube that referenced this issue Jun 26, 2023
@mszostok
Hackathon migration cli (kubeshop#384)
149ede2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug Fix e2e tests codenio/botkube
2 participants
@PrasadG193 @akankshakumari393