Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main helm chart deployment #1279

Merged
merged 25 commits into from
Oct 6, 2023
Merged

Main helm chart deployment #1279

merged 25 commits into from
Oct 6, 2023

Conversation

huseyinbabal
Copy link
Contributor

@huseyinbabal huseyinbabal commented Oct 3, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • It generates additional docker images with version containing commit id
  • Publishes the chart into gcs

Testing

Proof

You can see some testings I did on my personal git account below

Screenshot 2023-10-04 at 11 22 26

Publishing Helm Chart

https://github.com/huseyinbabal/botkube/actions/runs/6391937992/job/17348177345

Helm Chart Repo Add & Listing Versions

helm repo add gcs-botkube https://storage.googleapis.com/dev-botkube-latest-main-charts
helm repo update gcs-botkube
helm search repo gcs-botkube/botkube --devel

Related issue(s)

Relates #1203

@huseyinbabal huseyinbabal added ci Related to CI pipelines enhancement New feature or request labels Oct 3, 2023
@huseyinbabal huseyinbabal marked this pull request as ready for review October 4, 2023 07:36
@huseyinbabal huseyinbabal requested review from a team and josefkarasek October 4, 2023 07:36
josefkarasek
josefkarasek approved these changes Oct 6, 2023
View reviewed changes
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huseyinbabal huseyinbabal merged commit 130b555 into kubeshop:main Oct 6, 2023
@huseyinbabal huseyinbabal deleted the main-helm-chart branch October 6, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefkarasek josefkarasek josefkarasek approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
ci Related to CI pipelines enhancement New feature or request
Projects
Botkube
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @josefkarasek