Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix help message, send the core message over gRPC #1307

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Fix help message, send the core message over gRPC #1307

merged 4 commits into from
Nov 15, 2023

Conversation

mszostok
Copy link
Collaborator

Description

Changes proposed in this pull request:

  • Fix help message, send the core message over gRPC

Related issue(s)

@mszostok mszostok added the enhancement New feature or request label Nov 11, 2023
@mszostok mszostok requested a review from pkosiec November 14, 2023 18:15
@mszostok mszostok marked this pull request as ready for review November 14, 2023 18:15
@mszostok mszostok requested a review from PrasadG193 as a code owner November 14, 2023 18:15
@mszostok mszostok requested a review from a team November 14, 2023 18:15
pkosiec
pkosiec approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

pkg/execute/plugin_executor.go Outdated Show resolved Hide resolved
@mszostok mszostok enabled auto-merge (squash) November 15, 2023 13:49
@mszostok mszostok disabled auto-merge November 15, 2023 14:23
@mszostok mszostok merged commit 0fd6ce2 into kubeshop:main Nov 15, 2023
14 of 15 checks passed
@mszostok mszostok deleted the teams-msg branch November 15, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec