Improve stability of Slack E2E tests #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
added
enhancement
mszostok
approved these changes
Jul 2, 2024
mszostok
reviewed
Jul 2, 2024
| # uses: rtCamp/action-slack-notify@v2 | ||
| # if: ${{ failure() }} | ||
| # env: | ||
| # SLACK_CHANNEL: 'botkube-cloud-ci-alerts' |
There was a problem hiding this comment.
I found it much easier to change this line for test purposes, so I'm just sharing:
Suggested change
| # SLACK_CHANNEL: 'botkube-cloud-ci-alerts' | |
| SLACK_CHANNEL: 'test-botkube-ci-alerts' |
this way you still get useful notifications in case of failure on your PR
This reverts commit b3e3a32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description