Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable secrets endpoint #657

Merged
merged 3 commits into from
Oct 20, 2023
Merged

fix: enable secrets endpoint #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eadb02
fix: enable secrets endpoint
vsukhin Oct 16, 2023
0818f96
fix: comment typo
vsukhin Oct 16, 2023
630024c
Merge branch 'develop' into vsukhin/fix/config-security-endpoint
vsukhin Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/testkube-api/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ A Helm chart for Testkube api
| clusterName | string | `""` | |
| configValues | string | `""` | |
| dashboardUri | string | `""` | |
| enableSecretsEndpoint | bool | `false` | |
| executors | string | `""` | |
| extraEnvVars | object | `{}` | |
| fullnameOverride | string | `""` | |
Expand Down
2 changes: 2 additions & 0 deletions charts/testkube-api/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,8 @@ spec:
configMapKeyRef:
name: testkube-global-config
key: helmchartVersion
- name: ENABLE_SECRETS_ENDPOINT
value: "{{ .Values.enableSecretsEndpoint }}"
image: {{ include "testkube-api.image" . }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
Expand Down
3 changes: 3 additions & 0 deletions charts/testkube-api/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ dashboardUri: ""
## cluster name to be used in events
clusterName: ""

## enable endpoint to list testkube namespace secrets
enableSecretsEndpoint: false

## Testkube API resource requests and limits
resources:
{}
Expand Down
1 change: 1 addition & 0 deletions charts/testkube/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ kubectl label --overwrite crds scripts.tests.testkube.io app.kubernetes.io/manag
| testkube-api.cloud.url | string | `"agent.testkube.io:443"` | Testkube Cloud API URL |
| testkube-api.clusterName | string | `""` | |
| testkube-api.dashboardUri | string | `""` | |
| testkube-api.enableSecretsEndpoint | bool | `false` | enable endpoint to list testkube namespace secrets |
| testkube-api.executors | string | `""` | default executors as base64-encoded string |
| testkube-api.extraEnvVars | list | `[]` | Extra environment variables to be set on deployment |
| testkube-api.fullnameOverride | string | `"testkube-api-server"` | Testkube API full name override |
Expand Down
1 change: 1 addition & 0 deletions charts/testkube/values-demo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ testkube-api:
cdeventsTarget: ""
dashboardUri: ""
clusterName: ""
enableSecretsEndpoint: false

priorityClassName: "highest-priority"

Expand Down
1 change: 1 addition & 0 deletions charts/testkube/values-develop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ testkube-api:
cdeventsTarget: ""
dashboardUri: ""
clusterName: ""
enableSecretsEndpoint: false

priorityClassName: "highest-priority"

Expand Down
1 change: 1 addition & 0 deletions charts/testkube/values-stage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ testkube-api:
cdeventsTarget: "https://webhook.site/f99d020e-8815-4bed-963c-1ed7c54a0d0c"
dashboardUri: ""
clusterName: ""
enableSecretsEndpoint: false

priorityClassName: "highest-priority"

Expand Down
2 changes: 2 additions & 0 deletions charts/testkube/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,8 @@ testkube-api:
dashboardUri: ""
## cluster name to be used in events
clusterName: ""
## enable endpoint to list testkube namespace secrets
enableSecretsEndpoint: false

# Test Connection pod
testConnection:
Expand Down