Update github.com/kubeshop/kusk-gateway to v1.5.0
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
kylehodgetts
previously approved these changes
Dec 7, 2022
`server/kusk/client_test.go` ---------------------------- Define `upstream` in the `specs` string that is used in `TestCreateStaticRoute`. See, https://github.com/kubeshop/kusk-gateway/blob/main/examples/static-route/example-1-top-level-upstream/api.yaml, for what the new definition of `StaticRoute` should be. `server/kusk/client.go` ----------------------- Populate `staticRoute.Spec.Upstream` from `tmp.Spec.Upstream`. --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
mbana
changed the title
github.com/kubeshop/kusk-gateway to v1.5.0
mbana
previously approved these changes
Dec 7, 2022
There was a problem hiding this comment.
@jasmingacic and @kylehodgetts, could you possible try the change I pushed?
Here, https://github.com/kubeshop/kusk-gateway/blob/main/examples/static-route/example-1-top-level-upstream/api.yaml, is how the new StaticRoute structure looks.
…gistry) Example using `latest`: * ttl.sh/kubeshop/kusk-gateway-api:latest * ttl.sh/kubeshop/kusk-gateway-api-websocket:latest Example using latest `tag` name: * ttl.sh/kubeshop/kusk-gateway-api:v1.2.1 * ttl.sh/kubeshop/kusk-gateway-api-websocket:v1.2.1 --- Signed-off-by: Mohamed Bana <mohamed@bana.io>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server/kusk/client_test.goDefine
upstreamin thespecsstring that is used inTestCreateStaticRoute.See, https://github.com/kubeshop/kusk-gateway/blob/main/examples/static-route/example-1-top-level-upstream/api.yaml, for what the new definition of
StaticRouteshould be.server/kusk/client.goPopulate
staticRoute.Spec.Upstreamfromtmp.Spec.Upstream.Test
Signed-off-by: jasmingacic jasmin.gacic@gmail.com