fix: added container image test

kubeshop · Oct 20, 2023 · 75709e6 · 75709e6
1 parent e9ab59d
commit 75709e6
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/packages/e2e-tests/pages/ExecutorGeneralSettingsPage.ts b/packages/e2e-tests/pages/ExecutorGeneralSettingsPage.ts
@@ -20,6 +20,17 @@ export class ExecutorGeneralSettingsPage {
     expect(executorTypeLocator.isVisible()).toBeTruthy();
   }
 
+  public async selectContainerImageTab(): Promise<void> {
+    await this.page.click('div[data-test="sidebar-navigation-link:container-image"]');
+  }
+
+  public async validateContainerImageSettings(containerImage: string): Promise<void> {
+    const containerImageLocator = this.page.locator(
+      `//input[@id="container-image-settings-name-type_container_image" and @value="${containerImage}"]`
+    );
+    expect(containerImageLocator.isVisible()).toBeTruthy();
+  }
+
   public async deleteExecutor(executorName: string): Promise<void> {
     await this.page.click('button[data-testid="configuration-card-confirm-button"]');
     await this.page.getByTestId('delete-entity-input').fill(executorName);

diff --git a/packages/e2e-tests/tests/executors.spec.ts b/packages/e2e-tests/tests/executors.spec.ts
@@ -86,7 +86,30 @@ test(`Custom container executor - delete executor`, async ({page}) => {
   expect(isDeleted).toBeTruthy();
 });
 
-test.skip(`Custom container executor - container image`, async ({page}) => {});
+test(`Custom container executor - container image`, async ({page}) => {
+  const executorName = 'container-executor-curl-1';
+  const executorData = testDataHandler.getExecutor(executorName);
+  const realExecutorName = executorData.name;
+  await api.assureExecutorCreated(executorData);
+
+  const mainPage = new MainPage(page);
+  await mainPage.visitMainPage();
+
+  const navigationSiderPage = new NavigationSiderPage(page);
+  await navigationSiderPage.openMenuItem('executors');
+
+  const executorsPage = new ExecutorsPage(page);
+  await executorsPage.openExecutorSettings(realExecutorName);
+
+  const executorGeneralSettingsPage = new ExecutorGeneralSettingsPage(page);
+
+  await executorGeneralSettingsPage.selectContainerImageTab();
+
+  await executorGeneralSettingsPage.validateContainerImageSettings(executorData.image);
+
+  // Cleanup
+  await api.removeExecutor(realExecutorName);
+});
 
 test.skip(`Custom container executor - command and arguments`, async ({page}) => {});