Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: command args #888

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: command args #888

merged 1 commit into from
Sep 27, 2023

Conversation

mortada-codes
Copy link
Contributor

Changes

  • add namespace to the commands if it is different namespace than testkube

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 8:31am

Copy link
Member

@rangoo94 rangoo94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, although:

  • --namespace ${namespace} should be rather two arguments, so we will avoid problems if sanitizing it later (["--namespace", namespace])
  • Should the --namespace be passed as argument of the command? I'm not sure if it shouldn't be just after kubectl testkube, like kubectl testkube --namespace custom-name download artifacts

@mortada-codes mortada-codes merged commit bca09e8 into develop Sep 27, 2023
@mortada-codes mortada-codes deleted the mm/fix/clinamespace branch September 27, 2023 09:28
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants