fix: hide abort run when now running tests #902
Conversation
mortada-codes
requested review from
exu,
pavloburchak,
rangoo94 and
haneabogdan
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Could you rebase on top of |
| <PageTitle> | ||
| {title} {pageTitleAddon} | ||
| </PageTitle> | ||
| <Tooltip title={title}> |
There was a problem hiding this comment.
I'm not sure if a tooltip is a proper option. It may look strange, especially for short titles
There was a problem hiding this comment.
yes, me too. should we enable/disable based on the length of the title?
There was a problem hiding this comment.
In the best situation we should show it only when it's truncated. Quick googling shows that most likely it's possible, so it would be great if you could try it: https://stackoverflow.com/a/63214232/2922986
| const entityOptionsMenu = useMemo( | ||
| () => | ||
| [ | ||
| {key: 1, label: <span onClick={onEditTest}>Edit Test</span>}, |
There was a problem hiding this comment.
EntityDetailsHeader is not only used for tests, so the prop should be called onEdit and this label should be based on entity type, not static Edit Test
This PR...
Changes
1 We should safely remove “Abort all executions” if there is NO RUNNING execution. (make sure the it IS visible if there IS an execution running) - ideally this would be covered with an E2E test
2 Weird breaking on resize. The select boxes + buttons should be in the same line. The text is currently just cut… We typically use “ellipsis” to have the typo cut by “…” and display the whole title on hover
Fixes
How to test it
screenshots
Checklist