Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: REACT_APP environment variables resolution #905

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

rangoo94
Copy link
Member

Changes

  • the env.sh script was generating invalid JS, like {REACT_APP_XYZ=abc: "abc"}

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 2:55pm

@rangoo94 rangoo94 merged commit bd2c05d into develop Oct 11, 2023
6 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/react-env-resolution branch October 11, 2023 14:56
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants