Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve coverage collection for unit tests #909

Merged
merged 8 commits into from
Oct 17, 2023

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Oct 12, 2023

Changes

  • improve coverage collection for global npx jest / npm test command
    • collectCoverageFrom settings from projects are ignored, so need to be set on the top level
  • fix E2E tests for Triggers
  • add CodeClimate configuration
    • set pretty loose thresholds
    • send test coverage to CodeClimate

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 8:54am

@rangoo94 rangoo94 merged commit 68ad197 into develop Oct 17, 2023
@rangoo94 rangoo94 deleted the dawid/fix/coverage-collection branch October 17, 2023 08:56
haneabogdan pushed a commit that referenced this pull request Oct 24, 2023
* fix: improve coverage collection for unit tests

* feat: send Test Coverage results to the CodeClimate

* fixup codeclimate-action version

* chore: add CodeClimate configuration

* fixup codeclimate configuration

* fix: add a title for autocomplete options

* fix: Triggers E2E tests

* fixup adjust codeclimate configuration
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants