Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update colors for log parsing #926

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Update colors for log parsing #926

merged 1 commit into from
Nov 3, 2023

Conversation

pavloburchak
Copy link
Contributor

This PR...

Changes

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel Vercel
Copy link

vercel bot commented Nov 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 7:53pm

rangoo94
rangoo94 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@rangoo94 rangoo94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we shouldn't distinguish the background color for the log output (based on ANSI escape codes) and the one for log parsing, but LGTM - if we will have problems because of it, we may adjust that in the future 🙂

@pavloburchak pavloburchak merged commit ff9b803 into develop Nov 3, 2023
6 of 7 checks passed
@pavloburchak pavloburchak deleted the pavlo/styles-update-for-log-parsing branch November 3, 2023 15:41
haneabogdan pushed a commit that referenced this pull request Nov 6, 2023
@pavloburchak @haneabogdan
update colors (#926)
02a8c3e
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haneabogdan haneabogdan haneabogdan approved these changes

@rangoo94 rangoo94 rangoo94 approved these changes

@exu exu Awaiting requested review from exu exu is a code owner

@mortada-codes mortada-codes Awaiting requested review from mortada-codes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavloburchak @rangoo94 @haneabogdan