Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sanitize quotes in env-config.js #937

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Nov 9, 2023

Changes

  • Sanitize quotes in env.config.js

Fixes

Syntax error in env-config.js, like here because of REACT_APP_VERCEL_GIT_COMMIT_MESSAGE:

window._env_ = {
REACT_APP_VERSION: 'dev:vercel-preview',
REACT_APP_VERCEL_GIT_COMMIT_SHA: '7a85f0bc7042c8f851a644ca2582fb2b049ef9fd',
REACT_APP_VERCEL_URL: 'testkube-cloud-czwoia4vi-testkube-cloud.vercel.app',
REACT_APP_VERCEL_ENV: 'preview',
REACT_APP_VERCEL_GIT_PREVIOUS_SHA: '',
REACT_APP_VERCEL_GIT_COMMIT_AUTHOR_LOGIN: 'haneabogdan',
REACT_APP_VERCEL_GIT_PROVIDER: 'github',
REACT_APP_VERCEL_GIT_COMMIT_AUTHOR_NAME: 'haneabogdan',
REACT_APP_DISABLE_TELEMETRY: 'true',
REACT_APP_VERCEL_GIT_REPO_OWNER: 'kubeshop',
REACT_APP_VERCEL_GIT_REPO_SLUG: 'testkube-cloud-ui',
REACT_APP_VERCEL_GIT_PULL_REQUEST_ID: '',
REACT_APP_API_SERVER_ENDPOINT: 'https://api.testkube.dev',
REACT_APP_VERCEL_GIT_COMMIT_MESSAGE: '"Merge branch 'bogdan/feat/unsaved-changes-popup' of github.com:kubeshop/testkube-cloud-ui into bogdan/feat/unsaved-changes-popup"',
REACT_APP_VERCEL_GIT_REPO_ID: '',
REACT_APP_VERCEL_GIT_COMMIT_REF: 'bogdan/feat/unsaved-changes-popup',
};

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
testkube-dashboard 🔄 Building (Inspect) Visit Preview Nov 9, 2023 9:50am

@rangoo94 rangoo94 merged commit 5a38f51 into develop Nov 9, 2023
7 of 8 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/building-env-config branch November 9, 2023 09:54
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants