Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch validate fields so app doesn't crash TKC-863 #940

Merged

Conversation

topliceanurazvan
Copy link
Member

@topliceanurazvan topliceanurazvan commented Nov 15, 2023

Changes

  • Handle validateFields and don't crash the app on error

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview Nov 15, 2023 9:31am

@topliceanurazvan topliceanurazvan changed the title fix: catch validate fields so app doesn't crash #4622 fix: catch validate fields so app doesn't crash TKC-863 Nov 15, 2023
@rangoo94
Copy link
Member

I'm not sure if the error should be ignored, but looks rather OK 👍

@topliceanurazvan topliceanurazvan merged commit 79f0cfe into develop Nov 17, 2023
9 checks passed
@topliceanurazvan topliceanurazvan deleted the razvantopliceanu/fix/triggers-webhooks-forms branch November 17, 2023 09:51
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants