Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow running Docker with non-default user #964

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: allow running Docker with non-default user #964

merged 1 commit into from
Nov 28, 2023

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Nov 28, 2023 •
edited
Loading

Changes

  • Ensure that the default /usr/share/nginx/html and /etc/nginx directories in the container are writable by any user.

Fixes

How to test it

docker build -t tk-dash .
docker run --rm -u 1000756000:1000756000 -p 8080:8080 tk-dash

The server should successfully expose on 8080 port then

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 2:02pm

@rangoo94 rangoo94 changed the title fix: allow starting Docker with non-root user fix: allow starting Docker with non-default user Nov 28, 2023
@rangoo94 rangoo94 changed the title fix: allow starting Docker with non-default user fix: allow running Docker with non-default user Nov 28, 2023
@rangoo94 rangoo94 merged commit 6c345a9 into develop Nov 28, 2023
12 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/permissions-in-dockerfile branch November 28, 2023 15:01
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devcatalin devcatalin devcatalin approved these changes

@exu exu Awaiting requested review from exu exu is a code owner

@pavloburchak pavloburchak Awaiting requested review from pavloburchak

@haneabogdan haneabogdan Awaiting requested review from haneabogdan haneabogdan is a code owner

@topliceanurazvan topliceanurazvan Awaiting requested review from topliceanurazvan topliceanurazvan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @devcatalin