Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Support job-template argument for test creation. #3211

Closed
Sonlis opened this issue Feb 17, 2023 · 5 comments
Closed

UI: Support job-template argument for test creation. #3211

Sonlis opened this issue Feb 17, 2023 · 5 comments
Labels
🧾 documentation Improvements or additions to documentation

Comments

@Sonlis
Copy link
Contributor

Sonlis commented Feb 17, 2023

Is your feature request related to a problem? Please describe.
Related to this: #3209, it is for now impossible to specify a job template from the UI. This is useful for us as we can parameter env variables, service account, etc from the test CRD job-template's field.

Describe the solution you'd like
To have a field in the UI test creation step, where one can input a YAML of the job template.

Describe alternatives you've considered
This is doable with the CLI. What we thought of doing is having a pipeline, which has testkube-CLI installed, that would create tests instead of the test UI.

@Sonlis Sonlis added the feature-request 🚀 New feature request label Feb 17, 2023
@vsukhin vsukhin added this to Testkube Feb 17, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Testkube Feb 17, 2023
@TheBrunoLopes
Copy link
Collaborator

@fivenp do we need figma mockups for this ?

@TheBrunoLopes TheBrunoLopes added the service:dashboard 🎡 Testkube Web Dashboard label Feb 27, 2023
@cedricmckinnie
Copy link

Another issue related to jobTemplate is not being able to deploy it via GitOps. Perhaps it can be established as a ConfigMap and then assigned to a Test through the UI or in the Test CR by setting the ConfigMap name/key to .spec.executionRequest.jobTemplate?

@cedricmckinnie
Copy link

Nevermind, realizing now that the Test CR allows for defining .spec.executionRequest.jobTemplate as a multi-line string which gets merged into the dynamically-generated test runner pod's spec. i.e.

apiVersion: tests.testkube.io/v3
kind: Test
metadata:
  name: gingko-test
...
spec:
...
  executionRequest:
    jobTemplate: |
      spec:
        template:
          spec:
            serviceAccountName: my-service-account
            containers:
            - name: {{ .Name }}

Smart API and very clean solution. Might be a good thing to throw in the docs somewhere 😅

@vsukhin
Copy link
Collaborator

vsukhin commented Apr 19, 2023

thank you @cedricmckinnie need to update docs @TheBrunoLopes @aabedraba

@aabedraba aabedraba self-assigned this Jun 8, 2023
@aabedraba aabedraba added 🧾 documentation Improvements or additions to documentation and removed feature-request 🚀 New feature request service:dashboard 🎡 Testkube Web Dashboard labels Jun 8, 2023
@aabedraba aabedraba removed their assignment Jun 8, 2023
@aabedraba
Copy link

Will work on improving the docs.
Closing this issue for now.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Testkube Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

5 participants