Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Support using k8s secrets as git-token and git-username to authenticate to Github when creating tests from UI #3209

Open
Sonlis opened this issue Feb 17, 2023 · 6 comments
Assignees
Labels
feature-request 🚀 New feature request service:dashboard 🎡 Testkube Web Dashboard

Comments

@Sonlis
Copy link
Contributor

Sonlis commented Feb 17, 2023

Is your feature request related to a problem? Please describe.
Currently, if a test source is a git-dir, one can only specify directly a token and username to authenticate to Github when creating a test from the UI.
The CLI supports using secrets sitting in the cluster to authenticate, so the API fields already exists. There's just no way to do it from the UI.

Describe the solution you'd like
Being able to specify whether we want to configure the token from the UI or use already existing secrets in cluster to authenticate with Github.

Describe alternatives you've considered
I considered deploying a Mutating webhook server that would add those fields to the CRD when it's applied cluster-side, but since the API already supports such fields, it is just a matter of adding fields in the UI as well.

Additional context
This would be extremely useful for us as it would enable people who are not tech-oriented to create tests themselves. Also obvious security reasons of not sharing the git token to people.

@Sonlis Sonlis added the feature-request 🚀 New feature request label Feb 17, 2023
@Sonlis
Copy link
Contributor Author

Sonlis commented Feb 17, 2023

I am currently trying to implement it myself, but it would take a bit of time as I am not so frontend oriented. So if someone beats me to it, please do :D

@vsukhin vsukhin added this to Testkube Feb 17, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Testkube Feb 17, 2023
@vsukhin
Copy link
Collaborator

vsukhin commented Feb 17, 2023

@Sonlis thank you for such a detailed issue!

@TheBrunoLopes TheBrunoLopes added the service:dashboard 🎡 Testkube Web Dashboard label Feb 27, 2023
@TheBrunoLopes TheBrunoLopes moved this from 🆕 New to 🔖 Ready in Testkube Feb 28, 2023
@pavloburchak pavloburchak self-assigned this Mar 3, 2023
@pavloburchak pavloburchak moved this from 🔖 Ready to 🆕 New in Testkube Mar 13, 2023
@TheBrunoLopes
Copy link
Collaborator

@fivenp should we perhaps implement this from the test settings page ?

@pavloburchak pavloburchak removed their assignment May 18, 2023
@aabedraba
Copy link

@Sonlis is this an ongoing issue for you?

@fivenp
Copy link
Contributor

fivenp commented Jun 9, 2023

We wanted to implement this already some time ago – but the UI is currently blocked by this issue: #2842

@pavloburchak pavloburchak moved this from 🆕 New to ⛔️ Blocked in Testkube Sep 4, 2023
@pavloburchak pavloburchak moved this from ⛔️ Blocked to 🔖 Ready in Testkube Sep 12, 2023
@pavloburchak pavloburchak self-assigned this Sep 14, 2023
@pavloburchak pavloburchak moved this from 🔖 Ready to 🏗 In progress in Testkube Sep 14, 2023
@Sonlis
Copy link
Contributor Author

Sonlis commented Sep 14, 2023

Sorry for the late answer @aabedraba, yes it is still an ongoing issue for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request 🚀 New feature request service:dashboard 🎡 Testkube Web Dashboard
Projects
Status: 🏗 In progress
Development

No branches or pull requests

6 participants