-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Support using k8s secrets as git-token and git-username to authenticate to Github when creating tests from UI #3209
Comments
I am currently trying to implement it myself, but it would take a bit of time as I am not so frontend oriented. So if someone beats me to it, please do :D |
@Sonlis thank you for such a detailed issue! |
@fivenp should we perhaps implement this from the test settings page ? |
@Sonlis is this an ongoing issue for you? |
We wanted to implement this already some time ago – but the UI is currently blocked by this issue: #2842 |
Sorry for the late answer @aabedraba, yes it is still an ongoing issue for us. |
Is your feature request related to a problem? Please describe.
Currently, if a test source is a
git-dir
, one can only specify directly a token and username to authenticate to Github when creating a test from the UI.The CLI supports using secrets sitting in the cluster to authenticate, so the API fields already exists. There's just no way to do it from the UI.
Describe the solution you'd like
Being able to specify whether we want to configure the token from the UI or use already existing secrets in cluster to authenticate with Github.
Describe alternatives you've considered
I considered deploying a Mutating webhook server that would add those fields to the CRD when it's applied cluster-side, but since the API already supports such fields, it is just a matter of adding fields in the UI as well.
Additional context
This would be extremely useful for us as it would enable people who are not tech-oriented to create tests themselves. Also obvious security reasons of not sharing the git token to people.
The text was updated successfully, but these errors were encountered: