Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: select secrets #906

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat: select secrets #906

wants to merge 9 commits into from
+503 −243

Conversation

pavloburchak
Copy link
Contributor

@pavloburchak pavloburchak commented Oct 11, 2023 •
edited by rangoo94
Loading

This PR...

Changes

Fixes

How to test it

screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
testkube-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 9:45am

rangoo94
rangoo94 reviewed Oct 12, 2023
View reviewed changes
env-config.js Outdated Show resolved Hide resolved
@rangoo94
Copy link
Member

Description Screenshot
Looks like the Git source is not displayed for Tests, but I'm not sure if it's related to the ticket Zrzut ekranu 2023-10-13 o 13 38 54
I'm not sure if we should show "No options" for empty Zrzut ekranu 2023-10-13 o 13 44 31
There is no option to clear the username/token Zrzut ekranu 2023-10-13 o 13 45 34
The /secrets endpoint returns 404 on demo.testkube.dev - do we have already API for that? Zrzut ekranu 2023-10-13 o 13 46 26

@pavloburchak
Copy link
Contributor Author

Description Screenshot
Looks like the Git source is not displayed for Tests, but I'm not sure if it's related to the ticket Zrzut ekranu 2023-10-13 o 13 38 54
I'm not sure if we should show "No options" for empty Zrzut ekranu 2023-10-13 o 13 44 31
There is no option to clear the username/token Zrzut ekranu 2023-10-13 o 13 45 34
The /secrets endpoint returns 404 on demo.testkube.dev - do we have already API for that? Zrzut ekranu 2023-10-13 o 13 46 26

  1. Not relatad to this PR
  2. Do you want it to be hidden?
  3. Should there be?
  4. Yes we have, but not released

@rangoo94
Copy link
Member

  1. Not relatad to this PR
  2. Do you want it to be hidden?
  3. Should there be?
  4. Yes we have, but not released
  1. Created follow-up ticket: UI: Git source is not displayed in Test Settings testkube#4470
  2. @fivenp, what do you think?
  3. It should be, the User may put there data accidentally, and may want to delete it. Earlier you had "Clear username" / "Clear token" links
  4. Looks like the /secrets endpoint is available only when User will set enableSecretsEndpoint in the Helm Chart (here). @fivenp, how should we perform, when we cannot read secrets?

@pavloburchak
Copy link
Contributor Author

@rangoo94 I will add ability to clear the values

@rangoo94
Copy link
Member

rangoo94 commented Oct 18, 2023 •
edited
Loading

@pavloburchak, I'm not sure if @fivenp sent it to you, but looks like the Figma is updated and includes all of that: https://www.figma.com/file/asfUPepLHtyutWWR0pNGfK/Testkube-V2?type=design&node-id=3982-22830&mode=design

Of course, the "Log Parsing" has a higher priority for now though, so just adding it here for information completeness.

@haneabogdan haneabogdan force-pushed the pavlo/feat/secret-select branch from 1243668 to 845b661 Compare November 9, 2023 10:54
pavloburchak and others added 6 commits November 13, 2023 09:44
@pavloburchak @haneabogdan
tech: simplify configuration forms (#847)
d6ee131 
* chore: change types in ConfigurationCard
* chore: delete unused headerAction from ConfigurationCard
* fix: make FullWidthSpace block flex instead of inline-flex
* feat: add CardForm component that abstracts combined Form + ConfigurationCard behavior
* feat: use CardForm where it is expected
* fixup delete unnecessary Form[layout] from CardForm
* feat: unify initial values behavior
* fixup add layout prop for CardForm
* fix: add configurable spacing for CardForm items
* chore: inline initial values
* fixup spacing
* fixup variables
* chore: speed up initial values comparison a little
* fix: move ConfigurationCard's error handling to CardForm
* feat: add loading state for CardForms
* chore: simplify ConfigurationCard a little
* fix: simplify getting form validator
@pavloburchak @haneabogdan
fix rebase
a829784
@pavloburchak @haneabogdan
fix repo validation
318eec4
@pavloburchak @haneabogdan
remove build and public
c0c35b8
@pavloburchak @haneabogdan
rm env
7140c8f
@haneabogdan
WIP
9011566
@haneabogdan haneabogdan force-pushed the pavlo/feat/secret-select branch from 845b661 to 9011566 Compare November 13, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rangoo94 rangoo94 rangoo94 left review comments

@exu exu Awaiting requested review from exu exu is a code owner

@mortada-codes mortada-codes Awaiting requested review from mortada-codes

@haneabogdan haneabogdan Awaiting requested review from haneabogdan haneabogdan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavloburchak @rangoo94 @haneabogdan