Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TKC-2310): expose expression variables for simple use of org, env and dashboard #5722

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Aug 5, 2024

Pull request description

  • Expose dashboard.url variable, that will either point to OSS URL prefix, or to the Environment's URL prefix
  • Expose organization.id and environment.id (user-facing, not internal) variables

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Fixes

@rangoo94 rangoo94 requested review from a team as code owners August 5, 2024 08:09
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for testkube-docs-preview ready!

Name Link
🔨 Latest commit 613fddb
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/66b09519b70c2b0008d74712
😎 Deploy Preview https://deploy-preview-5722--testkube-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rangoo94 rangoo94 force-pushed the dawid/fix/TKC-2310-expose-dashboard-url-and-organization-environment-id branch from 32435fd to 51f7001 Compare August 5, 2024 08:12
@olensmar
Copy link
Member

olensmar commented Aug 5, 2024

thanks @rangoo94 - doc changes should be in the testkube-docs repo (I thought we were going to remove the docs from this repo to avoid confusion!?)

@rangoo94
Copy link
Member Author

rangoo94 commented Aug 5, 2024

thanks @rangoo94 - doc changes should be in the testkube-docs repo (I thought we were going to remove the docs from this repo to avoid confusion!?)

Thank you @olensmar! I've forgot about it 🤦 I'm pretty sure that even before vacations I made some changes to docs in there, for sure worth to delete it

@rangoo94 rangoo94 force-pushed the dawid/fix/TKC-2310-expose-dashboard-url-and-organization-environment-id branch from e117cd7 to 613fddb Compare August 5, 2024 09:02
@rangoo94 rangoo94 merged commit ec4a6a6 into develop Aug 5, 2024
11 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/TKC-2310-expose-dashboard-url-and-organization-environment-id branch August 5, 2024 12:16
rangoo94 added a commit that referenced this pull request Aug 14, 2024
rangoo94 added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants