-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TKC-2844): add credentials support #6045
Conversation
please resolve deprecated method issues |
@vsukhin, I'll try to do it later, although it's not a new code - I only moved it to a different file. |
@vsukhin, I have checked the client, and unfortunately, if we avoid the deprecated functions, we will lose access to the Connection Error. I don't think that we should do that yet - it happens that we are debugging based on that. |
ok, but library authors claim it as an especially bad approach) |
@vsukhin, yes, they write that, and I agree with their general statement:
But the thing is that we do not control infrastructure where Testkube will be installed, so for us it's very helpful to verify the initial gRPC connection immediately. It will change, when we will have a tooling for troubleshooting, but for now - it's the only way we are able to verify if there are no problems with gRPC connection (like incorrectly configured ingress/egress, or connection cut by some proxy). Even in that docs, they say:
But the thing is, that Given that, I don't think that we should change it at this point. We can consider it again:
|
Pull request description
credential()
function for Control Plane's credentialsChecklist (choose whats happened)
Fixes