-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [TKC-2966] Store TestWorkflowExecutionRequest config in TestWorkflowExecution #6070
Conversation
0bdf22e
to
e6e5757
Compare
for k, _ := range request.Config { | ||
if s, ok := schema[k]; ok && s.Sensitive { | ||
storeConfig = false | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure, but could be that iterating over workflow.Spec.Config
could be more correct - as a sensitive property set to default value may also be kind of sensitive (similar to uncertainty when working with PII rules - single information may not be sensitive, but in conjunction with others - it can become sensitive)
But, I guess, we can ignore that for now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding given users can mark their properties as sensitive, I think we can keep it as is?
I.e. if it's kind of sensitive in relation to others, you can still set it to sensitive, right? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.e. if it's kind of sensitive in relation to others, you can still set it to sensitive, right?
Yes, but I'm more saying about the default value - i.e. if you specify:
spec:
config:
apiUrl: { type: string, default: "my-value", sensitve: true }
And you request execution with config:
{}
The code above will save the configuration properly, despite it actually is using sensitive my-value
value.
As mentioned though, I think that we can ignore it for now :)
e6e5757
to
fc38298
Compare
for k, _ := range request.Config { | ||
if s, ok := schema[k]; ok && s.Sensitive { | ||
storeConfig = false | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.e. if it's kind of sensitive in relation to others, you can still set it to sensitive, right?
Yes, but I'm more saying about the default value - i.e. if you specify:
spec:
config:
apiUrl: { type: string, default: "my-value", sensitve: true }
And you request execution with config:
{}
The code above will save the configuration properly, despite it actually is using sensitive my-value
value.
As mentioned though, I think that we can ignore it for now :)
Pull request description
Store request config inside TestWorkflowExecution
Checklist (choose whats happened)
Breaking changes
Changes
Fixes